Merge pull request #39 from starspire/fix/patron-profile-hateoas-consistency

pilloPl · web-flow · commit 421ef2ddf48b · 2019-09-26T14:51:23.000+02:00
[FIX] Hateoas consistency and tests fixes
diff --git a/src/main/java/io/pillopl/library/lending/patronprofile/web/PatronProfileController.java b/src/main/java/io/pillopl/library/lending/patronprofile/web/PatronProfileController.java
@@ -53,8 +53,8 @@ class PatronProfileController {
     private final CancelingHold cancelingHold;
 
     @GetMapping("/profiles/{patronId}")
-    ResponseEntity<EntityModel<ProfileResource>> patronProfile(@PathVariable UUID patronId) {
-        return ok(new EntityModel<>(new ProfileResource(patronId)));
+    ResponseEntity<ProfileResource> patronProfile(@PathVariable UUID patronId) {
+        return ok(new ProfileResource(patronId));
     }
 
     @GetMapping("/profiles/{patronId}/holds/")

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@ class PatronProfileController {`
`53`	`53`	`private final CancelingHold cancelingHold;`
`54`	`54`
`55`	`55`	`@GetMapping("/profiles/{patronId}")`
`56`		`- ResponseEntity<EntityModel<ProfileResource>> patronProfile(@PathVariable UUID patronId) {`
`57`		`- return ok(new EntityModel<>(new ProfileResource(patronId)));`
	`56`	`+ ResponseEntity<ProfileResource> patronProfile(@PathVariable UUID patronId) {`
	`57`	`+ return ok(new ProfileResource(patronId));`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`@GetMapping("/profiles/{patronId}/holds/")`