Mock CancelingHold in HandleDuplicateHoldTest

Author: MarcinSwierczynski

src/main/java/io/pillopl/library/lending/patron/application/hold/HandleDuplicateHold.java

@@ -8,12 +8,24 @@
 import lombok.AllArgsConstructor;
 import org.springframework.context.event.EventListener;
 
+import java.time.Clock;
+
 import static java.time.Instant.now;
 
-@AllArgsConstructor
 public class HandleDuplicateHold {
 
     private final CancelingHold cancelingHold;
+    private final Clock clock;
+
+    public HandleDuplicateHold(CancelingHold cancelingHold) {
+        this.cancelingHold = cancelingHold;
+        this.clock = Clock.systemUTC();
+    }
+
+    public HandleDuplicateHold(CancelingHold cancelingHold, Clock clock) {
+        this.cancelingHold = cancelingHold;
+        this.clock = clock;
+    }
 
     @EventListener
     public Try<Result> handle(BookDuplicateHoldFound event) {
@@ -22,7 +34,7 @@ public Try<Result> handle(BookDuplicateHoldFound event) {
 
     private CancelHoldCommand cancelHoldCommandFrom(BookDuplicateHoldFound event) {
         return new CancelHoldCommand(
-                now(),
+                now(clock),
                 new PatronId(event.getSecondPatronId()),
                 new BookId(event.getBookId()));
     }

src/test/groovy/io/pillopl/library/lending/patron/application/hold/HandleDuplicateHoldTest.groovy

@@ -1,80 +1,54 @@
 package io.pillopl.library.lending.patron.application.hold
 
-import io.pillopl.library.commons.commands.Result
+import io.pillopl.library.catalogue.BookId
 import io.pillopl.library.lending.book.model.BookDuplicateHoldFound
-import io.pillopl.library.lending.book.model.BookOnHold
-import io.pillopl.library.lending.patron.model.Patron
-import io.pillopl.library.lending.patron.model.PatronEvent
-import io.pillopl.library.lending.patron.model.PatronFixture
 import io.pillopl.library.lending.patron.model.PatronId
-import io.pillopl.library.lending.patron.model.Patrons
-import io.vavr.control.Option
-import io.vavr.control.Try
 import spock.lang.Specification
 
+import java.time.Clock
+import java.time.Instant
+import java.time.ZoneOffset
+
 import static io.pillopl.library.lending.book.model.BookFixture.anyBookId
-import static io.pillopl.library.lending.book.model.BookFixture.bookOnHold
 import static io.pillopl.library.lending.librarybranch.model.LibraryBranchFixture.anyBranch
 import static io.pillopl.library.lending.patron.model.PatronFixture.anyPatronId
-import static io.pillopl.library.lending.patron.model.PatronFixture.regularPatron
 import static java.time.Instant.now
 
 class HandleDuplicateHoldTest extends Specification {
 
-    BookOnHold bookOnHold = bookOnHold()
-    PatronId patronId = anyPatronId()
-
-    FindBookOnHold willFindBook = { bookId, patronId -> Option.of(bookOnHold) }
-    Patrons repository = Stub()
+    CancelingHold cancelingHold = Mock()
 
-    def "should successfully cancel hold if book was hold by the patron"() {
+    def "should start cancelling hold if book was already hold by other patron"() {
         given:
-            CancelingHold cancelingHold = new CancelingHold(willFindBook, repository)
-            HandleDuplicateHold duplicateHold = new HandleDuplicateHold(cancelingHold)
+            Clock clock = Clock.fixed(Instant.parse('2020-02-27T12:21:00Z'), ZoneOffset.UTC)
         and:
-            persistedRegularPatronWithBookOnHold()
-        when:
-            Try<Result> result = duplicateHold.handle(duplicateHoldFoundBy(patronId))
-        then:
-            result.isSuccess()
-            result.get() == Result.Success
-    }
-
-    def "should reject cancelling hold if book was not hold by the patron"() {
-        given:
-            CancelingHold cancelingHold = new CancelingHold(willFindBook, repository)
-            HandleDuplicateHold duplicateHold = new HandleDuplicateHold(cancelingHold)
+            HandleDuplicateHold duplicateHold = new HandleDuplicateHold(cancelingHold, clock)
+        and:
+            BookDuplicateHoldFound bookDuplicateHoldFound = duplicateHoldFoundBy()
         and:
-            persistedRegularPatron()
+            CancelHoldCommand cancelHoldCommand = cancelHoldCommandFrom(bookDuplicateHoldFound, clock)
         when:
-            Try<Result> result = duplicateHold.handle(duplicateHoldFoundBy(patronId))
+            duplicateHold.handle(bookDuplicateHoldFound)
         then:
-            result.isSuccess()
-            result.get() == Result.Rejection
+            1 * cancelingHold.cancelHold(cancelHoldCommand)
     }
 
-    PatronId persistedRegularPatronWithBookOnHold() {
-        Patron patron = PatronFixture.regularPatronWithHold(bookOnHold)
-        repository.findBy(patronId) >> Option.of(patron)
-        repository.publish(_ as PatronEvent) >> patron
-        return patronId
-    }
-
-    PatronId persistedRegularPatron() {
-        Patron patron = regularPatron(patronId)
-        repository.findBy(patronId) >> Option.of(patron)
-        repository.publish(_ as PatronEvent) >> patron
-        return patronId
-    }
-
-    BookDuplicateHoldFound duplicateHoldFoundBy(PatronId patron) {
+    BookDuplicateHoldFound duplicateHoldFoundBy() {
         return new BookDuplicateHoldFound(
                 now(),
                 anyPatronId().patronId,
-                patron.patronId,
+                anyPatronId().patronId,
                 anyBranch().libraryBranchId,
                 anyBookId().bookId
         )
     }
 
+    CancelHoldCommand cancelHoldCommandFrom(BookDuplicateHoldFound event, Clock clock) {
+        return new CancelHoldCommand(
+                clock.instant(),
+                new PatronId(event.getSecondPatronId()),
+                new BookId(event.getBookId())
+        )
+    }
+
 }