Merge pull request #52 from MarcinSwierczynski/HandleDuplicateHold_Tests

Add unit tests for HandleDuplicateHold

Author: pilloPl

src/main/java/io/pillopl/library/lending/patron/application/hold/HandleDuplicateHold.java

@@ -5,15 +5,25 @@
 import io.pillopl.library.catalogue.BookId;
 import io.pillopl.library.lending.patron.model.PatronId;
 import io.vavr.control.Try;
-import lombok.AllArgsConstructor;
 import org.springframework.context.event.EventListener;
 
+import java.time.Clock;
+
 import static java.time.Instant.now;
 
-@AllArgsConstructor
 public class HandleDuplicateHold {
 
     private final CancelingHold cancelingHold;
+    private final Clock clock;
+
+    public HandleDuplicateHold(CancelingHold cancelingHold) {
+        this(cancelingHold, Clock.systemUTC());
+    }
+
+    public HandleDuplicateHold(CancelingHold cancelingHold, Clock clock) {
+        this.cancelingHold = cancelingHold;
+        this.clock = clock;
+    }
 
     @EventListener
     public Try<Result> handle(BookDuplicateHoldFound event) {
@@ -22,7 +32,7 @@ public Try<Result> handle(BookDuplicateHoldFound event) {
 
     private CancelHoldCommand cancelHoldCommandFrom(BookDuplicateHoldFound event) {
         return new CancelHoldCommand(
-                now(),
+                now(clock),
                 new PatronId(event.getSecondPatronId()),
                 new BookId(event.getBookId()));
     }

src/test/groovy/io/pillopl/library/lending/patron/application/hold/HandleDuplicateHoldTest.groovy

@@ -0,0 +1,54 @@
+package io.pillopl.library.lending.patron.application.hold
+
+import io.pillopl.library.catalogue.BookId
+import io.pillopl.library.lending.book.model.BookDuplicateHoldFound
+import io.pillopl.library.lending.patron.model.PatronId
+import spock.lang.Specification
+
+import java.time.Clock
+import java.time.Instant
+import java.time.ZoneOffset
+
+import static io.pillopl.library.lending.book.model.BookFixture.anyBookId
+import static io.pillopl.library.lending.librarybranch.model.LibraryBranchFixture.anyBranch
+import static io.pillopl.library.lending.patron.model.PatronFixture.anyPatronId
+import static java.time.Instant.now
+
+class HandleDuplicateHoldTest extends Specification {
+
+    CancelingHold cancelingHold = Mock()
+
+    def "should start cancelling hold if book was already hold by other patron"() {
+        given:
+            Clock clock = Clock.fixed(Instant.parse('2020-02-27T12:21:00Z'), ZoneOffset.UTC)
+        and:
+            HandleDuplicateHold duplicateHold = new HandleDuplicateHold(cancelingHold, clock)
+        and:
+            BookDuplicateHoldFound bookDuplicateHoldFound = duplicateHoldFoundBy()
+        and:
+            CancelHoldCommand cancelHoldCommand = cancelHoldCommandFrom(bookDuplicateHoldFound, clock)
+        when:
+            duplicateHold.handle(bookDuplicateHoldFound)
+        then:
+            1 * cancelingHold.cancelHold(cancelHoldCommand)
+    }
+
+    BookDuplicateHoldFound duplicateHoldFoundBy() {
+        return new BookDuplicateHoldFound(
+                now(),
+                anyPatronId().patronId,
+                anyPatronId().patronId,
+                anyBranch().libraryBranchId,
+                anyBookId().bookId
+        )
+    }
+
+    CancelHoldCommand cancelHoldCommandFrom(BookDuplicateHoldFound event, Clock clock) {
+        return new CancelHoldCommand(
+                clock.instant(),
+                new PatronId(event.getSecondPatronId()),
+                new BookId(event.getBookId())
+        )
+    }
+
+}