Add strict error handling to bash scripts (#123)

* Add strict error handling to bash scripts

Add "set -eu -o pipefail" to improve script reliability:
- Exit on undefined variables (-u)
- Exit on command failures (-e)
- Fail on pipe errors (-o pipefail)

* Remove unused, undefined variable

* Fix unbound variable

Author: mxr576

commands/web/eslint

@@ -7,6 +7,8 @@
 ## Example: "ddev eslint"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 if "$DDEV_DOCROOT/core/node_modules/.bin/eslint" --version >/dev/null ; then
   # Configure prettier
   test -e .prettierrc.json || ln -s $DDEV_DOCROOT/core/.prettierrc.json .

commands/web/expand-composer-json

@@ -7,9 +7,12 @@
 ## Example: "ddev expand-composer-json ctools"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 export _WEB_ROOT=$DDEV_DOCROOT
 cd "$DDEV_COMPOSER_ROOT" || exit
 curl -OL https://git.drupalcode.org/project/gitlab_templates/-/raw/default-ref/scripts/expand_composer_json.php
+_ddev_drupal_contrib_empty_composer=false
 if [[ ! -f composer.json ]]; then
   echo "{}" > composer.json
   _ddev_drupal_contrib_empty_composer=true

commands/web/nightwatch

@@ -7,4 +7,6 @@
 ## Example: "ddev nightwatch"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 yarn --cwd "$DDEV_DOCROOT/core" test:nightwatch  "$DDEV_APPROOT/$DDEV_DOCROOT/$DRUPAL_PROJECTS_PATH/" "$@"

commands/web/phpcbf

@@ -7,6 +7,8 @@
 ## Example: "ddev phpcbf" or "ddev phpcbf -n"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 if ! command -v phpcbf >/dev/null; then
   echo "phpcbf is not available. You may need to 'ddev composer install'"
   exit 1

commands/web/phpcs

@@ -7,6 +7,8 @@
 ## Example: "ddev phpcs" or "ddev phpcs -n"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 if ! command -v phpcs >/dev/null; then
   echo "phpcs is not available. You may need to 'ddev composer install'"
   exit 1

commands/web/phpstan

@@ -7,6 +7,8 @@
 ## Example: "ddev phpstan" or "ddev phpstan -n"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 if ! command -v phpstan >/dev/null; then
   echo "phpstan is not available. You may need to 'ddev poser'"
   exit 1

commands/web/phpunit

@@ -7,6 +7,8 @@
 ## Example: "ddev phpunit" or "ddev phpunit --stop-on-failure"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 if ! command -v phpunit >/dev/null; then
   echo "phpunit is not available. You may need to 'ddev composer install'"
   exit 1

commands/web/poser

@@ -7,8 +7,10 @@
 ## Example: "ddev poser" or "ddev poser --prefer-source"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 export COMPOSER=composer.contrib.json
-.ddev/commands/web/expand-composer-json "$DDEV_PROJECT_NAME"
+.ddev/commands/web/expand-composer-json
 composer install "$@"
 # The -f flag suppresses errors if lock file does not exist.
 rm -f composer.contrib.json composer.contrib.lock

commands/web/stylelint

@@ -7,6 +7,8 @@
 ## Example: "ddev stylelint"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 if $DDEV_DOCROOT/core/node_modules/.bin/stylelint --version >/dev/null ; then
   # Change directory to the project root folder
   cd "$DDEV_DOCROOT/$DRUPAL_PROJECTS_PATH/${DDEV_SITENAME//-/_}" || exit

commands/web/symlink-project

@@ -7,6 +7,8 @@
 ## Example: "ddev symlink-project"
 ## ExecRaw: true
 
+set -eu -o pipefail
+
 export _WEB_ROOT=$DDEV_DOCROOT
 #todo use more dynamic ref.
 cd "$DDEV_COMPOSER_ROOT" || exit