Skip to content

Commit 2fb30a5

Browse files
authored
Merge pull request #207 from team-florence/improve-rails-7-2-compatibility
Improve Rails 7.2 compatibility
2 parents 4d605eb + d88fabf commit 2fb30a5

File tree

3 files changed

+45
-0
lines changed

3 files changed

+45
-0
lines changed

meta_request/Dockerfile-rails-7.2

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
FROM ruby:3.1-alpine
2+
3+
RUN apk add --update --no-cache \
4+
build-base \
5+
curl-dev \
6+
git \
7+
nodejs \
8+
shared-mime-info \
9+
sqlite-dev \
10+
tzdata \
11+
yaml-dev \
12+
yarn \
13+
zlib-dev
14+
15+
RUN mkdir /app /gem
16+
WORKDIR /app
17+
18+
RUN gem update --system 3.5.7
19+
RUN bundle config force_ruby_platform true
20+
RUN gem install rails -v 7.2.1.1
21+
RUN rails new .
22+
23+
COPY . /gem
24+
RUN bundle add meta_request --path /gem
25+
RUN bundle install
26+
27+
COPY res/routes.rb /app/config/
28+
COPY res/dummy_controller.rb /app/app/controllers/
29+
COPY res/dummy /app/app/views/dummy
30+
COPY res/meta_request_test.rb /app/test/integration/
31+
32+
RUN bundle exec rails db:migrate
33+
34+
ENV PARALLEL_WORKERS 1
35+
36+
CMD ["bin/rake"]

meta_request/docker-compose.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,11 @@ services:
2121
build:
2222
context: .
2323
dockerfile: Dockerfile-rails-7.0
24+
test-rails-7.1:
25+
build:
26+
context: .
27+
dockerfile: Dockerfile-rails-7.1
28+
test-rails-7.2:
29+
build:
30+
context: .
31+
dockerfile: Dockerfile-rails-7.2

meta_request/lib/meta_request/event.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ def sanitize_hash(payload)
6666

6767
def not_encodable?(value)
6868
return true if defined?(ActiveRecord) && value.is_a?(ActiveRecord::ConnectionAdapters::AbstractAdapter)
69+
return true if defined?(ActiveRecord) && defined?(ActiveRecord::Transaction) && value.is_a?(ActiveRecord::Transaction)
6970
return true if defined?(ActionDispatch) && (value.is_a?(ActionDispatch::Request) || value.is_a?(ActionDispatch::Response))
7071
return true if defined?(ActionView) && value.is_a?(ActionView::Helpers::FormBuilder)
7172

0 commit comments

Comments
 (0)