Skip to content

finished all tasks #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

finished all tasks #106

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7fabde
finished all tasks
RalphOrland Sep 7, 2023
d4bfac1
added some suggestions
RalphOrland Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions db.json
View file
Open in desktop
Copy link
Member

@sbmsr sbmsr Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more descriptive key name like 'company_name' instead of 'name' for the 'companies' array items.

Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@
"companies": [
{
"id": 1,
"name": "Fusion LLC",
"company_name": "Fusion LLC",
"status": "Qualified Lead",
"created_at": "2021-04-27T03:41:56Z",
"account_executive": "Abigayle Gibson",
"revenue_ytd": 17000000
},
{
"id": 2,
"name": "Techopolis Ltd.",
"company_name": "Techopolis Ltd.",
"status": "Paying Customer",
"created_at": "2021-11-23T08:45:56Z",
"account_executive": "Joe Bond",
"revenue_ytd": 7375294
},
{
"id": 3,
"name": "Code learning LLC",
"company_name": "Code learning LLC",
"status": "Lead",
"created_at": "2022-04-15T12:45:56Z",
"account_executive": "Annie Ibarra",
Expand Down
Loading