Skip to content

Commit 1aae374

Browse files
fixed all issues
1 parent 8410a57 commit 1aae374

File tree

3 files changed

+38
-14
lines changed

3 files changed

+38
-14
lines changed

src/index.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<nav class="top">
1616
<div class="bar blue card left-align large">
1717
<a
18-
class="bar-item button hide-medium hide-large right padding-large hover-white large blue"
18+
class="bar-item button hide-large right padding-large hover-white large blue"
1919
href="javascript:void(0);"
2020
id="hamburger-button"
2121
onclick="toggleNav()"
@@ -24,14 +24,14 @@
2424
></a>
2525
<!-- TODO: Fix Issue, Desktop Nav Is Visible on Mobile -->
2626
<a id="nav-logo" class="bar-item button padding-large white">JobSimulator.Dev</a>
27-
<a id="nav-challenges" class="bar-item button padding-large hover-white">Browse Challenges</a>
28-
<a id="nav-signup" class="bar-item button padding-large hover-white">Sign Up</a>
27+
<a id="nav-challenges" href="#challenges" class="bar-item button hide-medium hide-small padding-large hover-white">Browse Challenges</a>
28+
<a id="nav-signup" href="#signup" class="bar-item button hide-medium hide-small padding-large hover-white">Sign Up</a>
2929
</div>
3030

3131
<!-- Navbar on small screens -->
32-
<div id="mobile-nav" class="bar-block white hide hide-large hide-medium large">
33-
<a id="mobile-nav-challenges" class="bar-item button padding-large">Browse Challenges</a>
34-
<a id="mobile-nav-signup" class="bar-item button padding-large">Sign Up</a>
32+
<div id="mobile-nav" class="bar-block white hide hide-large large">
33+
<a id="mobile-nav-challenges" href="#challenges" class="bar-item button padding-large">Browse Challenges</a>
34+
<a id="mobile-nav-signup" href="#signup" class="bar-item button padding-large">Sign Up</a>
3535
</div>
3636
</nav>
3737

src/script.js

Lines changed: 30 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,41 @@ let resetMessage = () => {
1919
document.getElementById("empty-error-message").hidden = true;
2020
};
2121

22-
addEventListener("submit", (event) => {
23-
event.preventDefault();
24-
resetMessage();
22+
let repeat_email = "";
2523

26-
let email = document.getElementById("email").value;
24+
addEventListener(
25+
"submit",
26+
(event) => {
27+
event.preventDefault();
28+
resetMessage();
2729

28-
// TODO: Show Correct Status Messages on Signup Form
29-
// 1. successful signup
30+
let email = document.getElementById("email").value;
31+
32+
// TODO: Show Correct Status Messages on Signup Form
33+
// 1. successful signup
34+
35+
if (email.length < 1) {
36+
renderEmailEmptyError();
37+
return;
38+
}
39+
if (email === repeat_email) {
40+
renderEmailTakenError();
41+
return;
42+
}
43+
for (let item of usersTable) {
44+
if (email === item.username) {
45+
renderEmailTakenError();
46+
return;
47+
}
48+
}
49+
renderSuccess();
50+
51+
repeat_email = email;
52+
}
3053
// 2. empty email
3154
// 3. taken email
3255
// 4. repeat email
33-
});
56+
);
3457

3558
let toggleNav = () => {
3659
var nav = document.getElementById("mobile-nav");

src/styles.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,6 +670,7 @@ form > span {
670670
#jumbo-image {
671671
max-height: 20rem;
672672
/* TODO: Invert banner colors using CSS */
673+
filter: invert(85%);
673674
}
674675

675676
@media (max-width: 600px) {
@@ -877,7 +878,7 @@ form > span {
877878
#challenge-grid {
878879
display: grid;
879880
/* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */
880-
grid-template-columns: none;
881+
grid-template-columns: 1fr 1fr;
881882
grid-auto-rows: 10rem;
882883
gap: 1rem;
883884
padding-top: 2rem;

0 commit comments

Comments
 (0)