Skip to content

Commit cedcbdd

Browse files
committed
fixed Issues
1 parent 69f9fa0 commit cedcbdd

File tree

3 files changed

+19
-6
lines changed

3 files changed

+19
-6
lines changed

src/index.html

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,18 @@
2323
><i class="fa fa-bars"></i
2424
></a>
2525
<!-- TODO: Fix Issue, Desktop Nav Is Visible on Mobile -->
26-
<a id="nav-logo" class="bar-item button padding-large white">JobSimulator.Dev</a>
27-
<a id="nav-challenges" class="bar-item button padding-large hover-white">Browse Challenges</a>
28-
<a id="nav-signup" class="bar-item button padding-large hover-white">Sign Up</a>
26+
<a id="nav-logo" class="bar-item button padding-large white" href="#header">JobSimulator.Dev</a>
27+
28+
<div id="desktop-nav" class="hide-small">
29+
<a id="nav-challenges" class="bar-item button padding-large hover-white" href="#challenges">Browse Challenges</a>
30+
<a id="nav-signup" class="bar-item button padding-large hover-white" href="#signup">Sign Up</a>
31+
</div>
2932
</div>
3033

3134
<!-- Navbar on small screens -->
3235
<div id="mobile-nav" class="bar-block white hide hide-large hide-medium large">
33-
<a id="mobile-nav-challenges" class="bar-item button padding-large">Browse Challenges</a>
34-
<a id="mobile-nav-signup" class="bar-item button padding-large">Sign Up</a>
36+
<a id="mobile-nav-challenges" class="bar-item button padding-large" href="#challenges">Browse Challenges</a>
37+
<a id="mobile-nav-signup" class="bar-item button padding-large" href="#signup">Sign Up</a>
3538
</div>
3639
</nav>
3740

src/script.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,15 @@ addEventListener("submit", (event) => {
3030
// 2. empty email
3131
// 3. taken email
3232
// 4. repeat email
33+
if (email === "") return renderEmailEmptyError()
34+
35+
for (const user of usersTable)
36+
{
37+
if(user.username === email) return renderEmailTakenError()
38+
}
39+
40+
usersTable.push({username: email})
41+
renderSuccess()
3342
});
3443

3544
let toggleNav = () => {

src/styles.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,6 +670,7 @@ form > span {
670670
#jumbo-image {
671671
max-height: 20rem;
672672
/* TODO: Invert banner colors using CSS */
673+
filter: invert(1);
673674
}
674675

675676
@media (max-width: 600px) {
@@ -877,7 +878,7 @@ form > span {
877878
#challenge-grid {
878879
display: grid;
879880
/* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */
880-
grid-template-columns: none;
881+
grid-template-columns: repeat(2, 1fr);
881882
grid-auto-rows: 10rem;
882883
gap: 1rem;
883884
padding-top: 2rem;

0 commit comments

Comments
 (0)