Finalize tests

Author: devpro

samples/terraform-local-exec/main.tf

@@ -1,8 +1,8 @@
 terraform {
   backend "http" {
-    address                = "http://localhost:5293/state/demo_devpro"
-    lock_address           = "http://localhost:5293/state/demo_devpro/lock"
-    unlock_address         = "http://localhost:5293/state/demo_devpro/lock"
+    address                = "http://localhost:5293/state/demo_localexec"
+    lock_address           = "http://localhost:5293/state/demo_localexec/lock"
+    unlock_address         = "http://localhost:5293/state/demo_localexec/lock"
     lock_method            = "POST"
     unlock_method          = "DELETE"
     username               = "admin"
@@ -16,3 +16,12 @@ resource "null_resource" "test_backend" {
     command = "echo 'Testing HTTP backend state management' > test.txt"
   }
 }
+
+resource "local_file" "test" {
+  content  = "Test HTTP backend"
+  filename = "${path.module}/temp.txt"
+}
+
+resource "random_string" "test" {
+  length = 16
+}

samples/terraform-local-exec/test.txt

@@ -40,8 +40,6 @@ public async Task<List<StateLockModel>> FindAllAsync()
 
         public async Task<StateLockModel> CreateAsync(StateLockModel input)
         {
-            input.Id = ObjectId.GenerateNewId().ToString();
-            input.Created = DateTime.UtcNow.ToString("yyyy-MM-ddTHH:mm:ss.fff+00:00");
             await _modelCollection.InsertOneAsync(input);
             return input;
         }

src/Infrastructure.MongoDb/Repositories/StateLockRepository.cs

@@ -114,7 +114,7 @@ public async Task<IActionResult> Unlock(string name, [FromBody] StateLockModel i
         var existingLock = await stateLockRepository.FindOneAsync(name);
         if (existingLock != null)
         {
-            if (!string.IsNullOrEmpty(lockId))
+            if (string.IsNullOrEmpty(lockId))
             {
                 return StatusCode(423, new { Message = "The state is locked." });
             }

src/WebApi/Controllers/StateController.cs

@@ -1,7 +1,5 @@
 using System.Net.Http.Headers;
 using Devpro.TerraformBackend.Domain.Models;
-using Microsoft.AspNetCore.Hosting;
-using Microsoft.Extensions.Configuration;
 
 namespace Devpro.TerraformBackend.WebApi.IntegrationTests;
 
@@ -15,7 +13,9 @@ public abstract class IntegrationTestBase(WebApplicationFactory<Program> factory
 
     protected Faker<StateModel> StateFaker { get; } = new Faker<StateModel>("en");
 
-    protected Faker<StateLockModel> StateLockFaker { get; } = new Faker<StateLockModel>("en");
+    protected Faker<StateLockModel> StateLockFaker { get; } = new Faker<StateLockModel>("en")
+        .RuleFor(u => u.Id, f => Guid.NewGuid().ToString())
+        .RuleFor(o => o.Created, f => DateTime.UtcNow.ToString("yyyy-MM-ddTHH:mm:ss.fff+00:00"));
 
     protected HttpClient CreateClient(bool isAuthorizationNeeded = false)
     {

test/WebApi.IntegrationTests/IntegrationTestBase.cs

@@ -1,4 +1,5 @@
-using Devpro.TerraformBackend.WebApi.IntegrationTests.Http;
+using System.Net;
+using Devpro.TerraformBackend.WebApi.IntegrationTests.Http;
 
 namespace Devpro.TerraformBackend.WebApi.IntegrationTests.Resources;
 
@@ -18,7 +19,7 @@ public async Task StateResource_GetNotExisting_ReturnsNoContent()
         var response = await client.GetAsync($"/state/{name}");
 
         // Assert
-        await response.CheckResponseAndGetContent(System.Net.HttpStatusCode.NoContent, null);
+        await response.CheckResponseAndGetContent(HttpStatusCode.NoContent, null);
     }
 
     [Fact]
@@ -35,7 +36,7 @@ public async Task StateResource_CreateNew_ReturnsCreated()
 
         // Assert
         //TODO: test resource URL in response
-        await response.CheckResponseAndGetContent(System.Net.HttpStatusCode.OK, null, string.Empty);
+        await response.CheckResponseAndGetContent(HttpStatusCode.OK, null, string.Empty);
     }
 
     [Fact]
@@ -45,9 +46,22 @@ public async Task StateResource_LockLifeCycle_IsSuccess()
         var client = CreateClient(true);
         var name = Faker.Random.Word();
         var stateLock = StateLockFaker.Generate();
+        var payload = GeneratePayload();
 
         // Act & Assert
         var createLockResponse = await client.PostAsync($"/state/{name}/lock", Serialize(stateLock));
-        await createLockResponse.CheckResponseAndGetContent(System.Net.HttpStatusCode.OK, "application/json; charset=utf-8", null);
+        await createLockResponse.CheckResponseAndGetContent(HttpStatusCode.OK, "application/json; charset=utf-8", null);
+        var deleteLockRequest = new HttpRequestMessage(HttpMethod.Delete, $"/state/{name}/lock")
+        {
+            Content = Serialize(stateLock)
+        };
+        var missingLockIdUpdateResponse = await client.PostAsync($"/state/{name}", payload);
+        await missingLockIdUpdateResponse.CheckResponseAndGetContent(HttpStatusCode.Locked, "application/json; charset=utf-8", "{\"message\":\"The state is locked.\"}");
+        var wrongLockIdUpdateResponse = await client.PostAsync($"/state/{name}?ID=1234", payload);
+        await wrongLockIdUpdateResponse.CheckResponseAndGetContent(HttpStatusCode.Conflict, "text/plain; charset=utf-8", "LockId doesn't match with the existing lock");
+        var updateResponse = await client.PostAsync($"/state/{name}?ID={stateLock.Id}", payload);
+        await updateResponse.CheckResponseAndGetContent(HttpStatusCode.OK, null, string.Empty);
+        var deleteLockResponse = await client.SendAsync(deleteLockRequest);
+        await deleteLockResponse.CheckResponseAndGetContent(HttpStatusCode.OK, null);
     }
 }