rename sshDisableStrictHostKeyChecking to sshStrictHostKeyChecking

Author: christianaye

README.md

@@ -173,10 +173,9 @@ spotlessChangelog { // all defaults
   commitMessage 'Published release/{{version}}' // {{version}} will be replaced
   remote 'origin'
   branch 'main'
-  // default value is false, but if you set it to true, then it will
+  // default value is `yes`, but if you set it to `no`, then it will
   // disable ssh host key checking (.ssh/known_hosts).
-  // Can also set by command line arg `-PsshDisableStrictHostKeyChecking`.
-  sshDisableStrictHostKeyChecking false
+  sshStrictHostKeyChecking "yes" // can override with `-PsshStrictHostKeyChecking=no`
 }
 
 // last version parsed from changelog

spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitActions.java

@@ -73,7 +73,7 @@ public void checkCanPush() throws GitAPIException, IOException {
 			}
 			push(cfg.branch, RemoteRefUpdate.Status.UP_TO_DATE);
 		} catch (GitAPIException e) {
-			throw new IllegalArgumentException("You can set user/pass with any of these environment variables: " + envVars() + ", or try -PsshDisableStrictHostKeyChecking on ssh remotes", e);
+			throw new IllegalArgumentException("You can set user/pass with any of these environment variables: " + envVars() + ", or try -PsshStrictHostKeyChecking=no on ssh remotes", e);
 		}
 	}
 
@@ -133,7 +133,7 @@ private void push(Consumer<PushCommand> cmd, RemoteRefUpdate.Status expected) th
 				sshTransport.setSshSessionFactory(new JschConfigSessionFactory() {
 					@Override
 					protected void configure(OpenSshConfig.Host host, Session session) {
-						session.setConfig("StrictHostKeyChecking", cfg.disableStrictHostKeyChecking ? "no" : "yes");
+						session.setConfig("StrictHostKeyChecking", cfg.sshStrictHostKeyChecking);
 					}
 				});
 			});

spotless-changelog-lib/src/main/java/com/diffplug/spotless/changelog/GitCfg.java

@@ -29,7 +29,7 @@ public class GitCfg {
 	public String commitMessage = "Published release/" + COMMIT_MESSAGE_VERSION;
 	public String remote = "origin";
 	public String branch = "main";
-	public boolean disableStrictHostKeyChecking = false;
+	public String sshStrictHostKeyChecking = "yes";
 
 	/** Returns an api configured with this config. */
 	public GitActions withChangelog(File changelogFile, ChangelogAndNext model) throws IOException {

spotless-changelog-plugin-gradle/src/main/java/com/diffplug/spotless/changelog/gradle/ChangelogExtension.java

@@ -173,14 +173,14 @@ public void setAppendDashSnapshotUnless_dashPrelease(boolean appendSnapshot) {
 	}
 
 	/**
-	 * If you set this to true, then the ssh host key checking over ssh:// remotes will be disabled.
-	 * By default strict host key checking is enabled. Make sure that there is an entry
+	 * If you set this to `no`, then the ssh host key checking over ssh:// remotes will be disabled.
+	 * By default strict host key checking is `yes`. Make sure that there is an entry
 	 * in know_hosts file for given ssh remote.
-	 * You can also add `-PsshDisableStrictHostKeyChecking` to the gradle command.
-	 * In your buildscript you can disable checking with `sshDisableStrictHostKeyChecking = true`
+	 * You can also add `-PsshStrictHostKeyChecking=no` to the gradle command.
+	 * In your buildscript you can disable checking with `sshStrictHostKeyChecking = "no"`
 	 */
-	public void setSshDisableStrictHostKeyChecking(boolean disableStrictHostKeyChecking) {
-		gitCfg.disableStrictHostKeyChecking = disableStrictHostKeyChecking;
+	public void setSshStrictHostKeyChecking(String sshStrictHostKeyChecking) {
+		gitCfg.sshStrictHostKeyChecking = sshStrictHostKeyChecking;
 	}
 
 	// tag and push

spotless-changelog-plugin-gradle/src/main/java/com/diffplug/spotless/changelog/gradle/ChangelogPlugin.java

@@ -46,7 +46,9 @@ public void apply(Project project) {
 
 		ChangelogExtension extension = project.getExtensions().create(ChangelogExtension.NAME, ChangelogExtension.class, project);
 		project.getTasks().register(PrintTask.NAME, PrintTask.class, extension);
-		extension.gitCfg.disableStrictHostKeyChecking = project.getRootProject().findProperty("sshDisableStrictHostKeyChecking") != null;
+		if (project.getRootProject().hasProperty("sshStrictHostKeyChecking")) {
+			extension.gitCfg.sshStrictHostKeyChecking = (String) project.getRootProject().findProperty("sshStrictHostKeyChecking");
+		}
 
 		TaskProvider<CheckTask> check = project.getTasks().register(CheckTask.NAME, CheckTask.class, extension);
 		TaskProvider<BumpTask> bump = project.getTasks().register(BumpTask.NAME, BumpTask.class, extension);