Improved Form unit tests

Author: srtab

src/Forms/Form.php

@@ -130,8 +130,6 @@ public function __get(string $name)
 
             return $this->form_errors;
         }
-
-        return parent::__get($name);
     }
 
     /**

tests/unit/Forms/ExampleForm.php

@@ -17,6 +17,7 @@ protected static function setFields()
             "title" => new CharField(["required" => true]),
             "description" => new CharField(["widget" => Textarea::class, "max_length" => 10]),
             "email" => new EmailField(),
+            "disabled" => new CharField(["disabled" => true]),
         );
     }
 

tests/unit/Forms/FormTest.php

@@ -48,12 +48,19 @@ public function testFieldObjectAccess()
         $this->assertInstanceOf(BoundField::class, $form['email']);
     }
 
-    public function testErrors()
+    public function testGetErrors()
     {
         $form = new ExampleForm();
         $this->assertEmpty($form->errors);
     }
 
+    public function testGetNotDefinedAttribute()
+    {
+        $form = new ExampleForm();
+
+        $this->assertNull($form->undefined);
+    }
+
     public function testErrorsOfBoundedForm()
     {
         $form = new ExampleForm(["data" => array()]);
@@ -78,7 +85,7 @@ public function testClean()
         $this->assertEquals(array("Error on title"), (array) $form->getFieldErrors("title"));
     }
 
-    public function testCleanWithTowAddError()
+    public function testCleanWithTwoAddError()
     {
         $form = new ExampleForm(["data" => array("title" => "Title2")]);
         $this->assertEquals(array("Error on title 1", "Error on title 2"), (array) $form->getFieldErrors("title"));
@@ -102,6 +109,38 @@ public function testCleanEmail()
         $this->assertEquals(array("Error Processing Email"), (array) $form->getFieldErrors("email"));
     }
 
+    public function testGetCleanedData()
+    {
+        $form = new ExampleForm();
+        $this->assertEmpty($form->getCleanedData());
+    }
+
+    public function testGetCleanedField()
+    {
+        $form = new ExampleForm(["data" => array("title" => "title")]);
+        $form->isValid(); // force validation
+
+        $this->assertEquals("title", $form->getCleanedField("title"));
+        $this->assertEquals("", $form->getCleanedField("email"));
+        $this->assertNull($form->getCleanedField("unexistent"));
+    }
+
+    public function testGetNonFieldErrorsEmpty()
+    {
+        $form = new ExampleForm([]);
+        $result = $form->getNonFieldErrors();
+
+        $this->assertEquals(0, count($result));
+    }
+
+    public function testGetNonFieldErrors()
+    {
+        $form = new ExampleForm(["data" => array("email" => "test@unit.c")]);
+        $result = $form->getNonFieldErrors();
+
+        $this->assertEquals(1, count($result));
+    }
+
     public function testIsValidWithInvalidForm()
     {
         $form = new ExampleForm(["data" => array()]);
@@ -119,4 +158,37 @@ public function testIsValidWithNoDataBounded()
         $form = new ExampleForm();
         $this->assertFalse($form->IsValid());
     }
+
+    /**
+     * @expectedException UnexpectedValueException
+     * @expectedExceptionMessage Field 'unexistent' not found in PHPForm\Unit\Forms\ExampleForm.
+     * Choices are: title, description, email, disabled
+     */
+    public function testOffsetGetUnexistentField()
+    {
+        $form = new ExampleForm();
+        $form["unexistent"];
+    }
+
+    public function testOffsetExists()
+    {
+        $form = new ExampleForm();
+
+        $this->assertTrue(isset($form["disabled"]));
+        $this->assertFalse(isset($form["unexistent"]));
+    }
+
+    public function testOffsetUnset()
+    {
+        $form = new ExampleForm();
+        unset($form["disabled"]);
+
+        $this->assertFalse(isset($form["disabled"]));
+    }
+
+    public function testCount()
+    {
+        $form = new ExampleForm();
+        $this->assertEquals(4, count($form));
+    }
 }