Skip to content

Commit 8585f96

Browse files
committed
Ensure correct type for delete_obj() and update_obj() functions
Relates to issue #7, but is not an ideal fix.
1 parent 1e55421 commit 8585f96

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ tags = project.tags()
8686
member = project.add_member('user_id', gitlab3.ACCESS_LEVEL_GUEST)
8787
member.access_level = gitlab3.ACCESS_LEVEL_DEVELOPER
8888
member.save() # or project.update_member(member)
89-
project.delete_member('user_id')
89+
project.delete_member(member)
9090

9191
# Issues
9292
issues = project.issues(limit=10)

gitlab3/__init__.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,8 @@ def _add_edit_fn(api, name, parent):
191191
"""Create <PARENT_API>.update_name(obj) and <API>.save() functions"""
192192
fixed_url = api._q_url.replace('merge_requests', 'merge_request')
193193
def parent_fn(obj):
194+
if not isinstance(obj, api):
195+
raise TypeError("Expected instance of %s" % api)
194196
return obj.save()
195197
def self_fn(self):
196198
return self._put(fixed_url, data=self._get_data())
@@ -201,6 +203,8 @@ def self_fn(self):
201203
def _add_delete_fn(api, name, parent):
202204
"""Create <PARENT_API>.delete_name(obj) and <API>.delete() functions"""
203205
def parent_fn(obj):
206+
if not isinstance(obj, api):
207+
raise TypeError("Expected instance of %s" % api)
204208
return obj.delete()
205209
def self_fn(self):
206210
return self._delete(api._q_url)

0 commit comments

Comments
 (0)