Remove dead code, test packed refs directly

Author: tmcw

default-theme/index.js

@@ -83,10 +83,7 @@ module.exports = function (comments, options, callback) {
       }),
       renderSectionList: _.template(fs.readFileSync(path.join(__dirname, 'section_list._'), 'utf8'), {
         imports: imports
-      }),
-      highlight: function (str) {
-        return highlight(str);
-      }
+      })
     }
   });
 

lib/git/url_prefix.js

@@ -3,6 +3,17 @@ var path = require('path');
 var gitUrlParse = require('git-url-parse');
 var getRemoteOrigin = require('remote-origin-url');
 
+function parsePackedRefs(packedRefs, branchName) {
+  return packedRefs.split(/\n/)
+    .filter(function (line) {
+      return line[0] !== '#' && line[0] !== '^';
+    })
+    .reduce(function (memo, line) {
+      memo[line.split(' ')[1]] = line.split(' ')[0];
+      return memo;
+    }, {})[branchName];
+}
+
 /**
  * Given a a root directory, find its git configuration and figure out
  * the HTTPS URL at the base of that GitHub repository.
@@ -16,21 +27,18 @@ function getGithubURLPrefix(root) {
     var head = fs.readFileSync(path.join(root, '.git', 'HEAD'), 'utf8');
     var branch = head.match(/ref\: (.*)/);
     if (branch) {
-      var branchFileName = path.join(root, '.git', branch[1]);
+      var branchName = branch[1];
+      var branchFileName = path.join(root, '.git', branchName);
       var packedRefsName = path.join(root, '.git', 'packed-refs');
       var sha;
       if (fs.existsSync(branchFileName)) {
         sha = fs.readFileSync(branchFileName, 'utf8');
       } else if (fs.existsSync(packedRefsName)) {
-        sha = fs.readFileSync(packedRefsName, 'utf8')
-          .split(/\n/)
-          .filter(function (line) {
-            return line[0] !== '#' && line[0] !== '^';
-          })
-          .reduce(function (memo, line) {
-            memo[line.split(' ')[1]] = line.split(' ')[0];
-            return memo;
-          }, {})[branch[1]];
+        // packed refs are a compacted version of the refs folder. usually
+        // you have a folder filled with files that just contain sha
+        // hashes. since this folder can be really big, packed refs
+        // stores all the refs in one file instead.
+        sha = parsePackedRefs(fs.readFileSync(packedRefsName, 'utf8'), branchName);
       }
     } else {
       sha = head;
@@ -42,3 +50,4 @@ function getGithubURLPrefix(root) {
 }
 
 module.exports = getGithubURLPrefix;
+module.exports.parsePackedRefs = parsePackedRefs;

test/lib/git/url_prefix.js

@@ -3,7 +3,8 @@
 var test = require('tap').test,
   mock = require('mock-fs'),
   mockRepo = require('./mock_repo'),
-  getGithubURLPrefix = require('../../../lib/git/url_prefix');
+  getGithubURLPrefix = require('../../../lib/git/url_prefix'),
+  parsePackedRefs = getGithubURLPrefix.parsePackedRefs;
 
 test('getGithubURLPrefix', function (t) {
 
@@ -27,7 +28,14 @@ test('getGithubURLPrefix', function (t) {
 
   mock.restore();
 
+  t.end();
+});
 
-
+test('parsePackedRefs', function (t) {
+  var input = '# pack-refs with: peeled fully-peeled\n' +
+    '4acd658617928bd17ae7364ef2512630d97c007a refs/heads/babel-6\n' +
+    '11826ad98c6c08d00f4af77f64d3e2687e0f7dba refs/remotes/origin/flow-types';
+  t.equal(parsePackedRefs(input, 'refs/heads/babel-6'),
+    '4acd658617928bd17ae7364ef2512630d97c007a', 'Finds babel 6 ref');
   t.end();
 });