Validate connection security properties #3298
Merged
+129
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
force-pushed
the
fulghum/mutual_tls
branch
from
8ff29e9 to
56f150a
Compare
fulghum
force-pushed
the
fulghum/mutual_tls
branch
from
56f150a to
28046a3
Compare
fulghum
force-pushed
the
fulghum/mutual_tls
branch
from
28046a3 to
41c8c33
Compare
zachmu
approved these changes
Nov 14, 2025
| if !conn.TLSEnabled() { | ||
| return newAccessDeniedError(userEntry.User) | ||
| } | ||
| if userEntry.SslCipher != "" { |
Member
There was a problem hiding this comment.
Are these cases supposed to fall through like they do? i.e. is it meaningful / possible to set more than one?
Contributor
Author
There was a problem hiding this comment.
correct – you can set an SSL cipher constraint, as well as a cert subject and cert issuer constraint, so we only exit with an error if we detect one of the constraints isn't met, and fall through to check the other constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends authentication handlers to validate additional connection properties (e.g. SSL, X509 client cert, cert issuer, cert subject) when additional connection constraints have been configured for a user.
Note: tests for this functionality are in dolthub/dolt#10067
Related to dolthub/dolt#10008