[typescript-operations] Extract convertSchemaEnumToDeclarationBlockString and getNodeComment to visitor-plugin-common
#10520
+358
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57e46c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…to visitor-plugin-common to re-use in next major version
eddeee888
force-pushed
the
extract-enum-utility
branch
from
90a0c5a to
ded23c1
Compare
This was referenced Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to be able to generate enum from
typescript-operationsthe same waytypescriptplugin does.This PR extracts the following functions to
@graphql-codegen/vistitor-plugin-commonso we can re-use them:convertSchemaEnumToDeclarationBlockString: previously the main logic to convert GraphQL enum -> TypeScript enum intypescriptvisitor.getNodeComment: previously built intoBaseTypeVisitoras a method, this is now a utility functionRelated #10496
Type of change
Please delete options that are not relevant.
How Has This Been Tested?