Implement IServiceScope disposal when window is destroyed

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>

Author: Copilot

src/Controls/src/Core/Window/Window.cs

@@ -552,6 +552,11 @@ void IWindow.Destroying()
 
 			AlertManager.Unsubscribe();
 			Application?.RemoveWindow(this);
+			
+			// Dispose the window-scoped service scope
+			if (Handler?.MauiContext is MauiContext mauiContext)
+				mauiContext.DisposeWindowScope();
+			
 			Handler?.DisconnectHandler();
 		}
 

src/Controls/tests/Core.UnitTests/WindowsTests.cs

@@ -4,6 +4,7 @@
 using System.Linq;
 using System.Reflection;
 using System.Threading.Tasks;
+using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Maui.Graphics;
 using Xunit;
 
@@ -766,5 +767,38 @@ public async Task TwoKeysSameWindow()
 			Assert.Same(window, actual);
 			Assert.Empty(table);
 		}
+
+		[Fact]
+		public void WindowServiceScopeIsDisposedOnDestroying()
+		{
+			var serviceCollection = new ServiceCollection();
+			serviceCollection.AddTransient<TestScopedService>();
+			var serviceProvider = serviceCollection.BuildServiceProvider();
+
+			var scope = serviceProvider.CreateScope();
+			var mauiContext = new MauiContext(scope.ServiceProvider);
+			mauiContext.SetWindowScope(scope);
+
+			var window = new TestWindow(new ContentPage());
+			var handler = new WindowHandlerStub();
+			handler.SetMauiContext(mauiContext);
+			window.Handler = handler;
+
+			// Verify the scope service works before disposal
+			var service = mauiContext.Services.GetService<TestScopedService>();
+			Assert.NotNull(service);
+
+			// Destroy the window - this should dispose the scope
+			((IWindow)window).Destroying();
+
+			// After disposal, the scope should be disposed
+			// We can't directly test if scope is disposed, but we can test that trying to use it throws
+			Assert.Throws<ObjectDisposedException>(() => scope.ServiceProvider.GetService<TestScopedService>());
+		}
+
+		private class TestScopedService
+		{
+			public string TestProperty { get; set; } = "test";
+		}
 	}
 }

src/Core/src/MauiContext.cs

@@ -11,6 +11,7 @@ public class MauiContext : IMauiContext
 	{
 		readonly WrappedServiceProvider _services;
 		readonly Lazy<IMauiHandlersFactory> _handlers;
+		IServiceScope? _windowScope;
 
 #if ANDROID
 		readonly Lazy<Context?> _context;
@@ -53,6 +54,16 @@ internal void AddWeakSpecific<TService>(TService instance)
 			_services.AddSpecific(typeof(TService), static state => ((WeakReference)state).Target, new WeakReference(instance));
 		}
 
+		internal void SetWindowScope(IServiceScope scope)
+		{
+			_windowScope = scope;
+		}
+
+		internal void DisposeWindowScope()
+		{
+			_windowScope?.Dispose();
+		}
+
 		class WrappedServiceProvider : IServiceProvider
 		{
 			readonly ConcurrentDictionary<Type, (object, Func<object, object?>)> _scopeStatic = new();

src/Core/src/MauiContextExtensions.cs

@@ -47,7 +47,6 @@ public static IMauiContext MakeApplicationScope(this IMauiContext mauiContext, N
 		public static IMauiContext MakeWindowScope(this IMauiContext mauiContext, NativeWindow platformWindow, out IServiceScope scope)
 		{
 			// Create the window-level scopes that will only be used for the lifetime of the window
-			// TODO: We need to dispose of these services once the window closes
 			scope = mauiContext.Services.CreateScope();
 
 #if ANDROID
@@ -56,6 +55,9 @@ public static IMauiContext MakeWindowScope(this IMauiContext mauiContext, Native
 			var scopedContext = new MauiContext(scope.ServiceProvider);
 #endif
 
+			// Store the scope in the scoped context so it can be disposed when the window is destroyed
+			scopedContext.SetWindowScope(scope);
+
 			scopedContext.AddWeakSpecific(platformWindow);
 
 #if ANDROID