[XSG] disable lineinfo by default on Release (#32294)

helps mitigate #32049

Author: StephaneDelcroix

src/Controls/src/SourceGen/ProjectItem.cs

@@ -19,7 +19,11 @@ public bool EnableLineInfo
 				return true;
 			if (Options.IsDisabled("build_metadata.additionalfiles.LineInfo"))
 				return false;
-			return !Options.IsDisabled("build_property.MauiXamlLineInfo");
+			if (Options.IsEnabled("build_property.MauiXamlLineInfo"))
+				return true;
+			if (Options.IsDisabled("build_property.MauiXamlLineInfo"))
+				return false;
+			return Configuration.Equals("Debug", StringComparison.OrdinalIgnoreCase);
 		}
 	}
 

src/Controls/tests/SourceGen.UnitTests/InitializeComponent/LineInfoTests.cs

@@ -33,4 +33,35 @@ public void DiagnosticShowsLocationInInputXamlFile()
         var expectedFilePath = Path.Combine(Environment.CurrentDirectory, "Test.xaml");
         Assert.True(generatedCode.Contains(@$"#line 9 ""{expectedFilePath}""", StringComparison.Ordinal));
     }
+
+	[Fact]
+	public void LineInfoDisabledDefault()
+    {
+        var xaml =
+"""
+<?xml version="1.0" encoding="UTF-8"?>
+<ContentPage
+    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
+    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+    x:Class="Test.TestPage">
+    <ContentPage.Resources>
+        <ResourceDictionary>
+            <ResourceDictionary.MergedDictionaries>
+                <ResourceDictionary Source="Resources/Styles\Colors.xaml" />
+            </ResourceDictionary.MergedDictionaries>
+        </ResourceDictionary>
+    </ContentPage.Resources>
+</ContentPage>
+""";
+
+        var (result, _) = RunGenerator(xaml, string.Empty, lineinfo: "default");
+
+        var generatedCode = result.GeneratedTrees.Single(tree => Path.GetFileName(tree.FilePath) == "Test.xaml.xsg.cs").ToString();
+        var expectedFilePath = Path.Combine(Environment.CurrentDirectory, "Test.xaml");
+#if RELEASE
+        Assert.False(generatedCode.Contains(@$"#line 9 ""{expectedFilePath}""", StringComparison.Ordinal));        
+#else
+		Assert.True(generatedCode.Contains(@$"#line 9 ""{expectedFilePath}""", StringComparison.Ordinal));
+#endif
+    }
 }

src/Controls/tests/SourceGen.UnitTests/InitializeComponent/SourceGenXamlInitializeComponentTests.cs

@@ -11,15 +11,15 @@ namespace Microsoft.Maui.Controls.SourceGen.UnitTests;
 
 public class SourceGenXamlInitializeComponentTestBase : SourceGenTestsBase
 {
-	protected record AdditionalXamlFile(string Path, string Content, string? RelativePath = null, string? TargetPath = null, string? ManifestResourceName = null, string? TargetFramework = null, string? NoWarn = null, bool TreeOrder = false, bool Dry = false)
-		: AdditionalFile(Text: ToAdditionalText(Path, Content), Kind: "Xaml", RelativePath: RelativePath ?? Path, TargetPath: TargetPath, ManifestResourceName: ManifestResourceName, TargetFramework: TargetFramework, NoWarn: NoWarn);
+	protected record AdditionalXamlFile(string Path, string Content, string? RelativePath = null, string? TargetPath = null, string? ManifestResourceName = null, string? TargetFramework = null, string? NoWarn = null, string Lineinfo = "enable")
+		: AdditionalFile(Text: ToAdditionalText(Path, Content), Kind: "Xaml", RelativePath: RelativePath ?? Path, TargetPath: TargetPath, ManifestResourceName: ManifestResourceName, TargetFramework: TargetFramework, NoWarn: NoWarn, LineInfo: Lineinfo);
 
-	protected (GeneratorDriverRunResult result, string? text) RunGenerator(string xaml, string code, string noWarn = "", string targetFramework = "", string? path = null, bool treeOrder = false, bool dry = false)
+	protected (GeneratorDriverRunResult result, string? text) RunGenerator(string xaml, string code, string noWarn = "", string targetFramework = "", string? path = null, string lineinfo = "enable")
 	{
 		var compilation = CreateMauiCompilation();
 		compilation = compilation.AddSyntaxTrees(CSharpSyntaxTree.ParseText(code));
 		var workingDirectory = Environment.CurrentDirectory;
-		var xamlFile = new AdditionalXamlFile(Path.Combine(workingDirectory, path ?? "Test.xaml"), xaml, RelativePath: path ?? "Test.xaml", TargetFramework: targetFramework, NoWarn: noWarn, ManifestResourceName: $"{compilation.AssemblyName}.Test.xaml", TreeOrder: treeOrder, Dry: dry);
+		var xamlFile = new AdditionalXamlFile(Path.Combine(workingDirectory, path ?? "Test.xaml"), xaml, RelativePath: path ?? "Test.xaml", TargetFramework: targetFramework, NoWarn: noWarn, ManifestResourceName: $"{compilation.AssemblyName}.Test.xaml", Lineinfo: lineinfo);
 		var result = RunGenerator<CodeBehindGenerator>(compilation, xamlFile);
 		var generated = result.Results.SingleOrDefault().GeneratedSources.SingleOrDefault(gs => gs.HintName.EndsWith(".xsg.cs")).SourceText?.ToString();
 

src/Controls/tests/SourceGen.UnitTests/SourceGeneratorDriver.cs

@@ -18,7 +18,7 @@ public static class SourceGeneratorDriver
 {
 	private static MetadataReference[]? MauiReferences;
 
-	public record AdditionalFile(AdditionalText Text, string Kind, string RelativePath, string? TargetPath, string? ManifestResourceName, string? TargetFramework, string? NoWarn);
+	public record AdditionalFile(AdditionalText Text, string Kind, string RelativePath, string? TargetPath, string? ManifestResourceName, string? TargetFramework, string? NoWarn, string LineInfo="enable");
 
 	public static GeneratorDriverRunResult RunGenerator<T>(Compilation compilation, params AdditionalFile[] additionalFiles)
 		where T : IIncrementalGenerator, new()
@@ -154,8 +154,13 @@ public override bool TryGetValue(string key, [NotNullWhen(true)] out string? val
 					"build_metadata.additionalfiles.RelativePath" => _additionalFile.RelativePath,
 					"build_metadata.additionalfiles.Inflator" => "SourceGen",
 					"build_property.targetFramework" => _additionalFile.TargetFramework,
+#if RELEASE
+					"build_property.Configuration" => "Release",
+#else
+					"build_property.Configuration" => "Debug",
+#endif
 					"build_property.EnableMauiXamlDiagnostics" => "true",
-					"build_property.MauiXamlLineInfo" => "enable",
+					"build_property.MauiXamlLineInfo" => _additionalFile.LineInfo != "default" ?  _additionalFile.LineInfo : null,
 					"build_property.MauiXamlNoWarn" => _additionalFile.NoWarn,
 
 					_ => null