chore: simplify code.

Author: bhouston

packages/agent/src/tools/session/SessionTracker.ts

@@ -3,7 +3,7 @@ import { v4 as uuidv4 } from 'uuid';
 
 import { Logger } from '../../utils/logger.js';
 
-import { detectBrowsers, BrowserInfo } from './lib/browserDetectors.js';
+import { BrowserInfo } from './lib/browserDetectors.js';
 import {
   BrowserConfig,
   Session,
@@ -62,48 +62,6 @@ export class SessionTracker {
 
     // Set up cleanup handlers for graceful shutdown
     this.setupGlobalCleanup();
-
-    // Start browser detection in the background if logger is provided
-    if (this.logger) {
-      this.browserDetectionPromise = this.detectBrowsers();
-    }
-  }
-
-  /**
-   * Detect available browsers on the system
-   */
-  private async detectBrowsers(): Promise<void> {
-    if (!this.logger) {
-      this.detectedBrowsers = [];
-      return;
-    }
-
-    try {
-      this.detectedBrowsers = await detectBrowsers();
-      if (this.logger) {
-        this.logger.info(
-          `Detected ${this.detectedBrowsers.length} browsers on the system`,
-        );
-      }
-      if (this.detectedBrowsers.length > 0 && this.logger) {
-        this.logger.info('Available browsers:');
-        this.detectedBrowsers.forEach((browser) => {
-          if (this.logger) {
-            this.logger.info(
-              `- ${browser.name} (${browser.type}) at ${browser.path}`,
-            );
-          }
-        });
-      }
-    } catch (error) {
-      if (this.logger) {
-        this.logger.error(
-          'Failed to detect system browsers, disabling browser session tools:',
-          error,
-        );
-      }
-      this.detectedBrowsers = [];
-    }
   }
 
   // Register a new browser session
@@ -324,6 +282,10 @@ export class SessionTracker {
   public getSession(sessionId: string): Session {
     const session = this.browserSessions.get(sessionId);
     if (!session) {
+      console.log(
+        'getting session, but here are the sessions',
+        this.browserSessions,
+      );
       throw new BrowserError(
         'Session not found',
         BrowserErrorCode.SESSION_ERROR,
@@ -338,6 +300,10 @@ export class SessionTracker {
   public async closeSession(sessionId: string): Promise<void> {
     const session = this.browserSessions.get(sessionId);
     if (!session) {
+      console.log(
+        'closing session, but here are the sessions',
+        this.browserSessions,
+      );
       throw new BrowserError(
         'Session not found',
         BrowserErrorCode.SESSION_ERROR,

packages/agent/src/tools/session/lib/browserDetectors.ts

@@ -3,6 +3,8 @@ import fs from 'fs';
 import { homedir } from 'os';
 import path from 'path';
 
+import { Logger } from '../../../utils/logger.js';
+
 /**
  * Browser information interface
  */
@@ -231,7 +233,7 @@ export async function detectLinuxBrowsers(): Promise<BrowserInfo[]> {
  * Detect available browsers on the system
  * Returns an array of browser information objects sorted by preference
  */
-export async function detectBrowsers(): Promise<BrowserInfo[]> {
+export async function detectBrowsers(logger: Logger): Promise<BrowserInfo[]> {
   const platform = process.platform;
   let browsers: BrowserInfo[] = [];
 
@@ -246,7 +248,7 @@ export async function detectBrowsers(): Promise<BrowserInfo[]> {
       browsers = await detectLinuxBrowsers();
       break;
     default:
-      console.log(`Unsupported platform: ${platform}`);
+      logger.error(`Unsupported platform: ${platform}`);
       break;
   }
 

packages/agent/src/tools/session/sessionMessage.ts

@@ -104,6 +104,7 @@ export const sessionMessageTool: Tool<Parameters, ReturnType> = {
       // Get the session info
       const sessionInfo = browserTracker.getSessionById(instanceId);
       if (!sessionInfo) {
+        console.log(browserTracker.getSessions());
         throw new Error(`Session ${instanceId} not found`);
       }
 

packages/agent/src/tools/session/sessionStart.ts

@@ -82,7 +82,7 @@ export const sessionStartTool: Tool<Parameters, ReturnType> = {
         sessionConfig.preferredType = 'chromium';
 
         // Try to detect Chrome browser
-        const browsers = await detectBrowsers();
+        const browsers = await detectBrowsers(logger);
         const chrome = browsers.find((b) =>
           b.name.toLowerCase().includes('chrome'),
         );