Make DependencyTracker.kt not store rootProject or logger so that its serializable again (#313)

* Make DependencyTracker.kt not store rootProject or logger so that its serializable again

* Remove logger from filtering android tasks

* Fix sample app

Author: joshafeinberg

affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetector.kt

@@ -591,7 +591,7 @@ class AffectedModuleDetectorImpl(
      */
     private fun findDependentProjects(): Set<ProjectPath> {
         return changedProjects.flatMap { path ->
-            dependencyTracker.findAllDependents(path)
+            dependencyTracker.findAllDependents(path, logger)
         }.toSet()
     }
 

affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorPlugin.kt

@@ -227,7 +227,7 @@ class AffectedModuleDetectorPlugin : Plugin<Project> {
         val tracker = DependencyTracker(project, null)
         project.tasks.configureEach { task ->
             if (task.name.contains(ANDROID_TEST_PATTERN)) {
-                tracker.findAllDependents(project.projectPath).forEach { dependentProject ->
+                tracker.findAllDependents(project.projectPath, null).forEach { dependentProject ->
                     project.rootProject.findProject(dependentProject.path)?.tasks?.forEach { dependentTask ->
                         AffectedModuleDetector.configureTaskGuard(dependentTask)
                     }

affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/DependencyTracker.kt

@@ -28,7 +28,7 @@ import java.io.Serializable
  * Utility class that traverses all project dependencies and discover which modules depend on each
  * other. This is mainly used by [AffectedModuleDetector] to find out which projects should be run.
  */
-class DependencyTracker(private val rootProject: Project, private val logger: Logger?) : Serializable {
+class DependencyTracker(rootProject: Project, logger: Logger?) : Serializable {
 
     private val dependentList: Map<ProjectPath, Set<ProjectPath>> by lazy {
         val result = mutableMapOf<ProjectPath, MutableSet<ProjectPath>>()
@@ -52,7 +52,7 @@ class DependencyTracker(private val rootProject: Project, private val logger: Lo
         result
     }
 
-    fun findAllDependents(projectPath: ProjectPath): Set<ProjectPath> {
+    fun findAllDependents(projectPath: ProjectPath, logger: Logger? = null): Set<ProjectPath> {
         logger?.info("finding dependents of $projectPath")
         val result = mutableSetOf<ProjectPath>()
         fun addAllDependents(projectPath: ProjectPath) {