Issue #2863830 by mglaman: Disabled coupons still apply

Author: mglaman

modules/promotion/src/CouponStorage.php

@@ -13,7 +13,7 @@ class CouponStorage extends CommerceContentEntityStorage implements CouponStorag
    * {@inheritdoc}
    */
   public function loadByCode($code) {
-    $coupons = $this->loadByProperties(['code' => $code]);
+    $coupons = $this->loadByProperties(['code' => $code, 'status' => TRUE]);
 
     return reset($coupons);
   }

modules/promotion/tests/src/Kernel/CouponStorageTest.php

@@ -66,6 +66,16 @@ public function testLoadByCode() {
 
     $coupon_loaded = $this->couponStorage->loadByCode($coupon_code);
     $this->assertEquals($coupon->id(), $coupon_loaded->id());
+
+    $coupon_code = $this->randomMachineName();
+    $coupon = Coupon::create([
+      'code' => $coupon_code,
+      'status' => FALSE,
+    ]);
+    $coupon->save();
+
+    $coupon_loaded = $this->couponStorage->loadByCode($coupon_code);
+    $this->assertEmpty($coupon_loaded);
   }
 
 }