Skip to content

Update helpers.py to use netbox long / lat fields. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Update helpers.py to use netbox long / lat fields. #6

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
edada1d
Update helpers.py to use netbox long / lat fields.
NetworkSeb Apr 20, 2024
93f4691
Make sure Lat and Long are the right way around!
NetworkSeb Apr 20, 2024
a10435e
Get the Lon/Lat fields correct in the comments too..
NetworkSeb Apr 20, 2024
242fe8e
First pass at making VLAN optional
NetworkSeb May 3, 2024
b422a92
Remove VLAN
NetworkSeb May 3, 2024
69fbd6a
Remove filtering of devices
NetworkSeb May 3, 2024
974870a
Attempt to fix the filter by role (no longer device_role)
NetworkSeb May 3, 2024
5984616
role should be checked against a set of roles not just one
NetworkSeb May 3, 2024
c2d6b45
Just use all devices
NetworkSeb Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion netbox_device_map/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@


def get_device_location(device: Device) -> LatLon | None:
"""Extract device geolocation from special custom field"""
"""If netbox longitude and latitude fields are populated for a device then use them."""
if device.longitude and device.latitude:
return (device.longitude, device.latitude)
"""... Otherwise extract device geolocation from special custom field"""
if location_cf := device.custom_field_data.get(LOCATION_CF_NAME):
return tuple(map(float, location_cf.replace(' ', '').split(',', maxsplit=1)))

Expand Down