Commit 001199d
authored
open Input Screen from widgets, when enabled (#6931)
Task/Issue URL:
https://app.asana.com/1/137249556945/project/1208671518894266/task/1211589372131521?focus=true
### Description
When enabled, open the Input Screen from when the app is opened from a
widget.
### Steps to test this PR
- [x] Install the app from this branch.
- [x] Ensure you have some favorites added.
- [x] Go to Settings -> AI Features and enable the Search & Duck.ai
address bar.
- [x] Add a widget (variant with favorites) to the home screen.
- [x] Click on the widget's text box and verify that the Input Screen
doesn't open.
- [x] Go to Feature Flag Inventory and enable
`showInputScreenOnSystemSearchLaunch`.
- [x] Force close and reopen the app.
- [x] Click on the widget's text box and verify that the Input Screen
opens.
- [x] Verify that `m_sfbw_l` pixel is sent.
- [x] Minimize it.
- [x] Click on the widget's text box again and verify that the Input
Screen opens.
- [x] Click the back button and verify the screen closes and goes back
to the home screen.
- [x] Click on the widget's text box again and verify that the Input
Screen opens.
- [x] Try submitting a search query, verify it opens the browser in the
new tab and there's nothing else left in the task bar.
- [x] Click on the widget's text box again and verify that the Input
Screen opens.
- [x] Try submitting a chat prompt, verify it opens the browser in
Duck.ai fragment and there's nothing else left in the task bar.
- [x] Click on the Duck.ai icon in the widget and verify the browser in
Duck.ai fragment.
- [x] Go to Settings -> AI Features and disable Duck.ai altogether.
- [x] Click on the widget's text box and verify that the Input Screen
doesn't open.
- [x] Go to Settings -> AI Features and enable Duck.ai again.
- [x] Click on the widget's text box and verify that the Input Screen
opens.
- [x] Click on the favorite in the widget and verify it opens directly
in the browser.
### Known issues
- Installed apps can't be searched on the Input Screen when launched
from the widget.
- Clicking the "voice" button on the widget doesn't immediately open
voice search.
Both will be resolved in follow up PRs.1 parent f8dfd8b commit 001199d
File tree
5 files changed
+106
-2
lines changed- app/src/main/java/com/duckduckgo/app/systemsearch
- duckchat
- duckchat-api/src/main/java/com/duckduckgo/duckchat/api
- duckchat-impl/src
- main/java/com/duckduckgo/duckchat/impl
- feature
- test/kotlin/com/duckduckgo/duckchat/impl
5 files changed
+106
-2
lines changedLines changed: 54 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| 77 | + | |
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
| |||
85 | 87 | | |
86 | 88 | | |
87 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
88 | 94 | | |
89 | 95 | | |
90 | 96 | | |
| |||
148 | 154 | | |
149 | 155 | | |
150 | 156 | | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
151 | 185 | | |
152 | 186 | | |
153 | 187 | | |
| |||
191 | 225 | | |
192 | 226 | | |
193 | 227 | | |
194 | | - | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
195 | 233 | | |
196 | 234 | | |
197 | 235 | | |
| |||
220 | 258 | | |
221 | 259 | | |
222 | 260 | | |
223 | | - | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
224 | 276 | | |
225 | 277 | | |
226 | 278 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
61 | 66 | | |
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
| 263 | + | |
263 | 264 | | |
264 | 265 | | |
265 | 266 | | |
| |||
279 | 280 | | |
280 | 281 | | |
281 | 282 | | |
| 283 | + | |
282 | 284 | | |
283 | 285 | | |
284 | 286 | | |
| |||
389 | 391 | | |
390 | 392 | | |
391 | 393 | | |
| 394 | + | |
| 395 | + | |
392 | 396 | | |
393 | 397 | | |
394 | 398 | | |
| |||
600 | 604 | | |
601 | 605 | | |
602 | 606 | | |
| 607 | + | |
603 | 608 | | |
604 | 609 | | |
605 | 610 | | |
| |||
642 | 647 | | |
643 | 648 | | |
644 | 649 | | |
| 650 | + | |
| 651 | + | |
645 | 652 | | |
646 | 653 | | |
647 | 654 | | |
| |||
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
71 | 78 | | |
72 | 79 | | |
73 | 80 | | |
| |||
Lines changed: 33 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1014 | 1014 | | |
1015 | 1015 | | |
1016 | 1016 | | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
1017 | 1050 | | |
1018 | 1051 | | |
1019 | 1052 | | |
| |||
0 commit comments