Addressing PR feedback

Author: CDRussell

app/src/main/java/com/duckduckgo/app/bookmarks/dialog/BookmarkAddedConfirmationDialog.kt

@@ -17,7 +17,6 @@
 package com.duckduckgo.app.bookmarks.dialog
 
 import android.annotation.SuppressLint
-import android.app.Activity
 import android.content.Context
 import android.graphics.Typeface
 import android.text.Spannable
@@ -53,10 +52,10 @@ import com.google.android.material.R as MaterialR
 
 @SuppressLint("NoBottomSheetDialog")
 class BookmarkAddedConfirmationDialog(
-    activity: Activity,
+    context: Context,
     private val bookmarkFolder: BookmarkFolder?,
     private val promoPlugins: PluginPoint<BookmarkAddedPromotionPlugin>,
-) : BottomSheetDialog(activity) {
+) : BottomSheetDialog(context) {
 
     abstract class EventListener {
         /** Sets a listener to be invoked when favorite state is changed */

sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/promotion/bookmarks/addeddialog/SetupSyncBookmarkAddedPromo.kt

@@ -36,7 +36,6 @@ import com.duckduckgo.sync.impl.R
 import com.duckduckgo.sync.impl.promotion.SyncPromotions
 import com.squareup.anvil.annotations.ContributesMultibinding
 import kotlinx.coroutines.launch
-import kotlinx.coroutines.withContext
 import javax.inject.Inject
 
 @ContributesMultibinding(scope = ActivityScope::class)
@@ -102,9 +101,7 @@ class SetupSyncBookmarkAddedPromo @Inject constructor(
             onMenuItemClicked(hideButton) {
                 activity.lifecycleScope.launch(dispatchers.main()) {
                     rootView.gone()
-                    withContext(dispatchers.io()) {
-                        syncPromotions.recordBookmarkAddedDialogPromotionDismissed()
-                    }
+                    syncPromotions.recordBookmarkAddedDialogPromotionDismissed()
                 }
             }
         }