Skip to content

Commit d6e46c1

Browse files
committed
Fix favicon size handling for older OS versions in Favorites widget.
1 parent 5c145e2 commit d6e46c1

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

app/src/main/java/com/duckduckgo/widget/FavoritesWidgetItemFactory.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import android.appwidget.AppWidgetManager
2020
import android.content.Context
2121
import android.content.Intent
2222
import android.graphics.Bitmap
23+
import android.os.Build
2324
import android.os.Bundle
2425
import android.view.View
2526
import android.widget.RemoteViews
@@ -64,7 +65,11 @@ class FavoritesWidgetItemFactory(
6465
AppWidgetManager.INVALID_APPWIDGET_ID,
6566
)
6667

67-
private val faviconItemSize = context.resources.getDimension(CommonR.dimen.savedSiteGridItemFavicon).toInt()
68+
private val faviconItemSize = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S_V2) {
69+
context.resources.getDimension(CommonR.dimen.savedSiteGridItemFavicon).toInt()
70+
} else {
71+
context.resources.getDimension(R.dimen.oldOsVersionSavedSiteGridItemFavicon).toInt()
72+
}
6873
private val faviconItemCornerRadius = CommonR.dimen.searchWidgetFavoritesCornerRadius
6974

7075
private val maxItems: Int

app/src/main/res/values/dimens.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,5 @@
2222
<dimen name="recyclerViewTwoFabsBottomPadding">136dp</dimen>
2323
<dimen name="extraLargeShapeCornerRadius">24dp</dimen>
2424
<bool name="show_wing_animation">false</bool>
25+
<dimen name="oldOsVersionSavedSiteGridItemFavicon">24dp</dimen>
2526
</resources>

0 commit comments

Comments
 (0)