ntp: support empty strings in persistent storage (#1932)

* ntp: support empty strings in persistent storage

* return values as stored

Author: shakyShane

special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar.page.js

@@ -252,6 +252,11 @@ export class OmnibarPage {
             }
         }
     }
+
+    async clearsInput() {
+        await this.searchInput().hover();
+        await this.closeButton().click();
+    }
 }
 
 /**

special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar.persistence.spec.js

@@ -28,6 +28,17 @@ test.describe('omnibar widget persistence', () => {
         // back to second again
         await omnibar.didSwitchToTab('02', ['01', '02']);
         await omnibar.expectInputValue('dresses');
+
+        // now clear the input
+        await omnibar.clearsInput();
+
+        // first tab is all good...
+        await omnibar.didSwitchToTab('01', ['01', '02']);
+        await omnibar.expectInputValue('shoes');
+
+        /// ...but the tab where we cleared is still empty
+        await omnibar.didSwitchToTab('02', ['01', '02']);
+        await omnibar.expectInputValue('');
     });
     test('remembers `mode` across tabs', async ({ page }, workerInfo) => {
         const ntp = NewtabPage.create(page, workerInfo);

special-pages/pages/new-tab/app/tabs/PersistentValue.js

@@ -17,7 +17,7 @@ export class PersistentValue {
      * @param {T} args.value
      */
     update({ id, value }) {
-        if (string(id) && string(value)) {
+        if (string(id)) {
             this.#values.set(id, value);
         }
     }
@@ -63,7 +63,7 @@ export class PersistentValue {
     byId(id) {
         if (typeof id !== 'string') return null;
         const value = this.#values.get(id);
-        if (!value || !string(value)) return null;
+        if (value === undefined) return null;
         return value;
     }