bugbot suggestions

Author: mishushakov

python/tests/async/test_async_basic.py

@@ -11,6 +11,6 @@ async def test_basic(async_sandbox: AsyncSandbox):
 @pytest.mark.skip_debug
 async def test_secure_access(async_sandbox_factory):
     # Create sandbox with public traffic disabled (secure access)
-    async_sandbox = async_sandbox_factory(network={"allow_public_traffic": False})
+    async_sandbox = await async_sandbox_factory(network={"allow_public_traffic": False})
     result = await async_sandbox.run_code("x =1; x")
     assert result.text == "1"

python/tests/async/test_async_contexts.py

@@ -66,7 +66,7 @@ async def test_restart_context(async_sandbox: AsyncSandbox):
 
 @pytest.mark.skip_debug
 async def test_create_context_secure_traffic(async_sandbox_factory):
-    async_sandbox = async_sandbox_factory(network={"allow_public_traffic": False})
+    async_sandbox = await async_sandbox_factory(network={"allow_public_traffic": False})
     context = await async_sandbox.create_code_context()
 
     contexts = await async_sandbox.list_code_contexts()
@@ -79,7 +79,7 @@ async def test_create_context_secure_traffic(async_sandbox_factory):
 
 @pytest.mark.skip_debug
 async def test_remove_context_secure_traffic(async_sandbox_factory):
-    async_sandbox = async_sandbox_factory(network={"allow_public_traffic": False})
+    async_sandbox = await async_sandbox_factory(network={"allow_public_traffic": False})
     context = await async_sandbox.create_code_context()
 
     await async_sandbox.remove_code_context(context.id)
@@ -90,7 +90,7 @@ async def test_remove_context_secure_traffic(async_sandbox_factory):
 
 @pytest.mark.skip_debug
 async def test_list_contexts_secure_traffic(async_sandbox_factory):
-    async_sandbox = async_sandbox_factory(network={"allow_public_traffic": False})
+    async_sandbox = await async_sandbox_factory(network={"allow_public_traffic": False})
     contexts = await async_sandbox.list_code_contexts()
 
     # default contexts should include python and javascript
@@ -101,7 +101,7 @@ async def test_list_contexts_secure_traffic(async_sandbox_factory):
 
 @pytest.mark.skip_debug
 async def test_restart_context_secure_traffic(async_sandbox_factory):
-    async_sandbox = async_sandbox_factory(network={"allow_public_traffic": False})
+    async_sandbox = await async_sandbox_factory(network={"allow_public_traffic": False})
     context = await async_sandbox.create_code_context()
 
     # set a variable in the context

python/tests/conftest.py

@@ -53,7 +53,8 @@ async def factory(template_override=None, **kwargs):
         template_name = template_override or template
         kwargs.setdefault("timeout", timeout)
         kwargs.setdefault("debug", debug)
-        sandbox = await AsyncSandbox.create(template_name, network=network, **kwargs)
+        kwargs.setdefault("network", network)
+        sandbox = await AsyncSandbox.create(template_name, **kwargs)
 
         def kill():
             async def _kill():
@@ -84,6 +85,11 @@ def debug():
     return os.getenv("E2B_DEBUG") is not None
 
 
+@pytest.fixture
+def network():
+    return None
+
+
 @pytest.fixture(autouse=True)
 def skip_by_debug(request, debug):
     if request.node.get_closest_marker("skip_debug"):

python/tests/sync/test_basic.py

@@ -9,8 +9,8 @@ def test_basic(sandbox: Sandbox):
 
 
 @pytest.mark.skip_debug
-def test_secure_access(sandbox_factory):
-    sandbox = sandbox_factory(network={"allow_public_traffic": False})
+def test_secure_access(sandbox):
+    sandbox = sandbox(network={"allow_public_traffic": False})
     # Create sandbox with public traffic disabled (secure access)
     result = sandbox.run_code("x =1; x")
     assert result.text == "1"

python/tests/sync/test_contexts.py

@@ -66,8 +66,8 @@ def test_restart_context(sandbox: Sandbox):
 
 # Secure traffic tests (public traffic disabled)
 @pytest.mark.skip_debug
-def test_create_context_secure_traffic(sandbox_factory):
-    sandbox = sandbox_factory(network={"allow_public_traffic": False})
+def test_create_context_secure_traffic(sandbox):
+    sandbox = sandbox(network={"allow_public_traffic": False})
     context = sandbox.create_code_context()
 
     contexts = sandbox.list_code_contexts()
@@ -79,8 +79,8 @@ def test_create_context_secure_traffic(sandbox_factory):
 
 
 @pytest.mark.skip_debug
-def test_remove_context_secure_traffic(sandbox_factory):
-    sandbox = sandbox_factory(network={"allow_public_traffic": False})
+def test_remove_context_secure_traffic(sandbox):
+    sandbox = sandbox(network={"allow_public_traffic": False})
     context = sandbox.create_code_context()
 
     sandbox.remove_code_context(context.id)
@@ -90,8 +90,8 @@ def test_remove_context_secure_traffic(sandbox_factory):
 
 
 @pytest.mark.skip_debug
-def test_list_contexts_secure_traffic(sandbox_factory):
-    sandbox = sandbox_factory(network={"allow_public_traffic": False})
+def test_list_contexts_secure_traffic(sandbox):
+    sandbox = sandbox(network={"allow_public_traffic": False})
     contexts = sandbox.list_code_contexts()
 
     # default contexts should include python and javascript
@@ -101,8 +101,8 @@ def test_list_contexts_secure_traffic(sandbox_factory):
 
 
 @pytest.mark.skip_debug
-def test_restart_context_secure_traffic(sandbox_factory):
-    sandbox = sandbox_factory(network={"allow_public_traffic": False})
+def test_restart_context_secure_traffic(sandbox):
+    sandbox = sandbox(network={"allow_public_traffic": False})
     context = sandbox.create_code_context()
 
     # set a variable in the context