Fix field store ordering to match JCL getter

Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>

Author: fengxue-IS

runtime/vm/callin.cpp

@@ -589,7 +589,6 @@ initializeAttachedThreadImpl(J9VMThread *currentThread, const char *name, j9obje
 				currentThread->returnValue = J9_BCLOOP_RUN_METHOD;
 				currentThread->returnValue2 = (UDATA)J9VMJAVALANGTHREAD_INIT_METHOD(vm);
 				c_cInterpreter(currentThread);
-				J9VMJAVALANGTHREAD_SET_STARTED(currentThread, initializee->threadObject, JNI_TRUE);
 #if JAVA_SPEC_VERSION >= 19
 				j9object_t threadHolder = J9VMJAVALANGTHREAD_HOLDER(currentThread, initializee->threadObject);
 				if (NULL != threadHolder) {
@@ -598,6 +597,8 @@ initializeAttachedThreadImpl(J9VMThread *currentThread, const char *name, j9obje
 #else /* JAVA_SPEC_VERSION >= 19 */
 				J9VMJAVALANGTHREAD_SET_THREADSTATUS(currentThread, initializee->threadObject, J9VMTHREAD_STATE_RUNNING);
 #endif /* JAVA_SPEC_VERSION >= 19 */
+				/* Thread.started must be set after Thread.threadStatus to avoid timing issue in Thread.getState(). */
+				J9VMJAVALANGTHREAD_SET_STARTED(currentThread, initializee->threadObject, JNI_TRUE);
 			}
 		}
 done:

runtime/vm/threadhelp.cpp

@@ -118,13 +118,13 @@ monitorWaitImpl(J9VMThread *vmThread, j9object_t object, I_64 millis, I_32 nanos
 #endif
 		J9VMTHREAD_SET_BLOCKINGENTEROBJECT(vmThread, vmThread, object);
 		object = NULL;
+#if JAVA_SPEC_VERSION >= 24
+		J9VM_SEND_VIRTUAL_UNBLOCKER_THREAD_SIGNAL(javaVM);
+#endif /* JAVA_SPEC_VERSION >= 24 */
 		/* Set j.l.Thread status to WAITING. */
 		U_32 oldState = J9_ARE_ANY_BITS_SET(thrstate, J9_PUBLIC_FLAGS_THREAD_TIMED)
 				? VM_VMHelpers::setThreadState(vmThread, J9VMTHREAD_STATE_WAITING_TIMED)
 				: VM_VMHelpers::setThreadState(vmThread, J9VMTHREAD_STATE_WAITING);
-#if JAVA_SPEC_VERSION >= 24
-		J9VM_SEND_VIRTUAL_UNBLOCKER_THREAD_SIGNAL(javaVM);
-#endif /* JAVA_SPEC_VERSION >= 24 */
 		internalReleaseVMAccessSetStatus(vmThread, thrstate);
 		rc = timeCompensationHelper(vmThread,
 			interruptable ? HELPER_TYPE_MONITOR_WAIT_INTERRUPTABLE : HELPER_TYPE_MONITOR_WAIT_TIMED, monitor, millis, nanos);

runtime/vm/vmthread.cpp

@@ -1868,8 +1868,19 @@ startJavaThread(J9VMThread * currentThread, j9object_t threadObject, UDATA priva
 	privateFlags &= ~J9_PRIVATE_FLAGS_NO_EXCEPTION_IN_START_JAVA_THREAD;
 
 #ifndef J9VM_IVE_RAW_BUILD /* J9VM_IVE_RAW_BUILD is not enabled by default */
+#if JAVA_SPEC_VERSION >= 19
+	j9object_t threadHolder = J9VMJAVALANGTHREAD_HOLDER(currentThread, threadObject);
+	if (NULL != threadHolder) {
+		J9VMJAVALANGTHREADFIELDHOLDER_SET_THREADSTATUS(currentThread, threadHolder, J9VMTHREAD_STATE_RUNNING);
+	}
+#else /* JAVA_SPEC_VERSION >= 19 */
+	J9VMJAVALANGTHREAD_SET_THREADSTATUS(currentThread, threadObject, J9VMTHREAD_STATE_RUNNING);
+#endif /* JAVA_SPEC_VERSION >= 19 */
 	/* Any attempt to start a Thread makes it illegal to attempt to start it again.
-	 * Oracle class libraries don't have the 'started' field */
+	 * Oracle class libraries don't have the 'started' field.
+	 *
+	 * Thread.started must be set after Thread.threadStatus to avoid timing issue in Thread.getState().
+	 */
 	J9VMJAVALANGTHREAD_SET_STARTED(currentThread, threadObject, TRUE);
 #endif /* !J9VM_IVE_RAW_BUILD */
 
@@ -2033,9 +2044,6 @@ startJavaThreadInternal(J9VMThread * currentThread, UDATA privateFlags, UDATA os
 	}
 	J9VMJAVALANGTHREAD_SET_THREADREF(currentThread, threadObject, newThread);
 
-	/* Set j.l.Thread status to RUNNABLE. */
-	VM_VMHelpers::setThreadState(currentThread, J9VMTHREAD_STATE_RUNNING);
-
 #if (JAVA_SPEC_VERSION >= 14)
 	/* If thread was interrupted before start, make sure interrupt flag is set for running thread. */
 	if (J9VMJAVALANGTHREAD_DEADINTERRUPT(currentThread, threadObject)) {