-
Notifications
You must be signed in to change notification settings - Fork 778
Update the compiler target, arch, tune for Java 25+ #22968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4e11729 to
f60e2b9
Compare
|
https://hyc-runtimes-jenkins.swg-devops.com/view/IBM%20Java%20zOS/job/Build_JDK25_s390x_zos_Personal/493/console Changed to ready for review |
|
jenkins test sanity.functional zos jdk25 |
|
No infra is currently available to test externally, but @Deigue's internal build looks good. Tracking that there are still filesystem-related tasks pending before internal builds can consume this change. Since the internal machines use a different branch and do not directly consume the HEAD branch, merging this PR should be safe. That said, @joransiu, I will leave the decision to merge this PR to you when you assess that it is safe for internal builds. |
| set(OMR_ZOS_COMPILE_TUNE 10 CACHE STRING "") | ||
| elseif (JAVA_SPEC_VERSION GREATER_EQUAL 25) | ||
| set(OMR_ZOS_COMPILE_TARGET "zOSV3R1" CACHE STRING "") | ||
| set(OMR_ZOS_COMPILE_ARCHITECTURE 10 CACHE STRING "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since z/OSV3R1 pre-reqs z14 [1], we should take the opportunity to bump up the OMR_ZOS_COMPILE_ARCHITECTURE to 12 too. TUNE can be set to latest hardware level supported by the compiler (presumably 14 (z16) or 15 (z17)).
[1] https://www.ibm.com/docs/en/zos/3.1.0?topic=installation-hardware-software-requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.ibm.com/docs/en/open-xl-c-cpp-zos/2.2.0?topic=new-z17-support
Will set tuning to 15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this will force a dependency on Open XL 2.2, assuming z17 level is not recognized on 2.1. Using TUNE=14 for z16 is probably good enough, as z17 processor implementation is just an evolution of z16. That will give us the flexibility to still compile successfully with Open XL 2.1,
Java 25 for z/OS will be using Open XL 2.2. Java 25 will pre-req z/OS 3.1+ This updates the target level as a result of this requirement. Updates the architectures and tuning accordingly too. Signed-off-by: Gaurav Chaudhari <Gaurav.Chaudhari@ibm.com>
Java 25 for z/OS will be using Open XL 2.2, which requires z/OS 3.1+ This updates the target level as a result of this requirement.