-
Notifications
You must be signed in to change notification settings - Fork 778
Introduce a constantPool cache v2 #22974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yet to reproduce the issue on xlinux, so maybe there is a non obvious platform dependency here. |
|
jenkins test sanity.openjdk amac jdk21 |
jcl/src/java.base/share/classes/java/lang/invoke/MethodHandleResolver.java
Show resolved
Hide resolved
|
What's different in this one? |
Nothing, Im just trying to reproduce the failure with more debug info. |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity plinux jdk17 |
eaa45af to
4facbef
Compare
|
jenkins test sanity.openjdk amac jdk21 |
6cbee62 to
7736698
Compare
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity.openjdk amac jdk21 depends eclipse-omr/omr#8060 |
|
jenkins test sanity.openjdk amac jdk21 depends eclipse-omr/omr#8060 |
|
jenkins test sanity.openjdk amac jdk21 depends eclipse-omr/omr#8060 |
7a77dec to
f8439cb
Compare
|
jenkins test sanity.openjdk amac jdk21 |
|
jenkins test sanity amac jdk17 |
|
jenkins test sanity xlinux jdk17 |
|
@gacholio Changes are ready for another look |
|
I will need to squash the commits |
|
The OMR change you were depending on is in draft state. NM, looks like it's no longer a dependency. |
|
jenkins test sanity xlinux jdk17 |
|
jenkins test sanity amac jdk17 |
|
jenkins test sanity.openjdk amac jdk21 |
Cache the constantPool object off the j.l.Class after the first invocation of Access::getConstantPool. Given that the ConstantPool instance is associated with a single version of the class, as soon as the class is redefined the cache is invalidated and disabled. Signed-off-by: tajila <atobia@ca.ibm.com>
Addresses compilation failure caused by eclipse-openj9#22974 Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Addresses compilation failure caused by eclipse-openj9#22974 Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Cache the constantPool object off the j.l.Class after the first invocation of Access::getConstantPool. Given that the ConstantPool instance is associated with a single version of the class, as soon as the class is redefined the cache is invalidated and disabled.