Skip to content

Conversation

@tajila
Copy link
Contributor

@tajila tajila commented Nov 18, 2025

Cache the constantPool object off the j.l.Class after the first invocation of Access::getConstantPool. Given that the ConstantPool instance is associated with a single version of the class, as soon as the class is redefined the cache is invalidated and disabled.

@tajila tajila requested a review from gacholio November 18, 2025 21:43
@tajila
Copy link
Contributor Author

tajila commented Nov 18, 2025

Yet to reproduce the issue on xlinux, so maybe there is a non obvious platform dependency here.

@tajila
Copy link
Contributor Author

tajila commented Nov 18, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Nov 19, 2025

@gacholio
Copy link
Contributor

What's different in this one?

@tajila
Copy link
Contributor Author

tajila commented Nov 19, 2025

What's different in this one?

Nothing, Im just trying to reproduce the failure with more debug info.

@tajila
Copy link
Contributor Author

tajila commented Nov 20, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Nov 20, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Nov 21, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Nov 21, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Nov 21, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Nov 21, 2025

jenkins test sanity plinux jdk17

@tajila tajila force-pushed the opt branch 3 times, most recently from eaa45af to 4facbef Compare November 24, 2025 15:24
@tajila
Copy link
Contributor Author

tajila commented Nov 24, 2025

jenkins test sanity.openjdk amac jdk21

@tajila tajila force-pushed the opt branch 2 times, most recently from 6cbee62 to 7736698 Compare November 24, 2025 22:57
@tajila
Copy link
Contributor Author

tajila commented Nov 24, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Nov 25, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Nov 26, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Dec 2, 2025

jenkins test sanity.openjdk amac jdk21 depends eclipse-omr/omr#8060

@tajila
Copy link
Contributor Author

tajila commented Dec 2, 2025

jenkins test sanity.openjdk amac jdk21 depends eclipse-omr/omr#8060

@tajila
Copy link
Contributor Author

tajila commented Dec 3, 2025

jenkins test sanity.openjdk amac jdk21 depends eclipse-omr/omr#8060

@tajila tajila force-pushed the opt branch 3 times, most recently from 7a77dec to f8439cb Compare December 3, 2025 22:25
@tajila
Copy link
Contributor Author

tajila commented Dec 3, 2025

jenkins test sanity.openjdk amac jdk21

@tajila
Copy link
Contributor Author

tajila commented Dec 4, 2025

jenkins test sanity amac jdk17

@tajila
Copy link
Contributor Author

tajila commented Dec 4, 2025

jenkins test sanity xlinux jdk17

@tajila tajila marked this pull request as ready for review December 4, 2025 13:46
@tajila
Copy link
Contributor Author

tajila commented Dec 4, 2025

@gacholio Changes are ready for another look

@tajila
Copy link
Contributor Author

tajila commented Dec 4, 2025

I will need to squash the commits

@tajila
Copy link
Contributor Author

tajila commented Dec 4, 2025

@gacholio
Copy link
Contributor

gacholio commented Dec 4, 2025

The OMR change you were depending on is in draft state.

NM, looks like it's no longer a dependency.

@gacholio
Copy link
Contributor

gacholio commented Dec 5, 2025

jenkins test sanity xlinux jdk17

@gacholio
Copy link
Contributor

gacholio commented Dec 5, 2025

jenkins test sanity amac jdk17

@gacholio
Copy link
Contributor

gacholio commented Dec 5, 2025

jenkins test sanity.openjdk amac jdk21

Cache the constantPool object off the j.l.Class after the first
invocation of Access::getConstantPool. Given that the ConstantPool
instance is associated with a single version of the class, as soon as
the class is redefined the cache is invalidated and disabled.

Signed-off-by: tajila <atobia@ca.ibm.com>
@gacholio gacholio merged commit dc1af14 into eclipse-openj9:master Dec 5, 2025
2 checks passed
tajila added a commit to tajila/openj9 that referenced this pull request Dec 6, 2025
Addresses compilation failure caused by eclipse-openj9#22974

Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
tajila added a commit to tajila/openj9 that referenced this pull request Dec 7, 2025
Addresses compilation failure caused by eclipse-openj9#22974

Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants