added tests to debug #945 ignored for now but once tests are refactored so we can start nodes in desired states they should become relevant again

Author: Mpdreamz

src/Elasticsearch.Net/Connection/RequestState/TransportRequestState.cs

@@ -5,6 +5,7 @@
 using System.Linq;
 using System.Text;
 using Elasticsearch.Net.Connection.Configuration;
+using Elasticsearch.Net.ConnectionPool;
 using PurifyNet;
 
 namespace Elasticsearch.Net.Connection.RequestState
@@ -29,6 +30,15 @@ public IRequestConfiguration RequestConfiguration
 			}
 		}
 
+		public bool UsingPooling
+		{
+			get
+			{
+				var pool = this.ClientSettings.ConnectionPool;
+				return pool != null && pool.GetType() != typeof(SingleNodeConnectionPool);
+			}
+		}
+
 		public string Method { get; private set; }
 
 		public string Path { get; private set; }

src/Nest/ElasticClient-DoRequest.cs

@@ -8,7 +8,7 @@ namespace Nest
 	public partial class ElasticClient
 	{
 		/// <summary>
-		/// Perform any request you want over the configured IConnection synchronously while taking advantage of the cluster failover.
+		/// Perform any request you want over the configured IConnection while taking advantage of the cluster failover.
 		/// </summary>
 		/// <typeparam name="T">The type representing the response JSON</typeparam>
 		/// <param name="method">the HTTP Method to use</param>

src/Tests/Nest.Tests.Integration/IntegrationSetup.cs

@@ -8,42 +8,41 @@
 using Nest.Tests.MockData.Domain;
 using NUnit.Framework;
 
-	[SetUpFixture]
-	public class SetupAndTeardownForIntegrationTests
+[SetUpFixture]
+public class SetupAndTeardownForIntegrationTests
+{
+	[SetUp]
+	public void Setup()
 	{
-		[SetUp]
-		public void Setup()
-		{
-			var client = new ElasticClient(
-				//ElasticsearchConfiguration.Settings(hostOverride: new Uri("http://localhost:9200"))
-				ElasticsearchConfiguration.Settings()
-			);
-
-			try
-			{
-				IntegrationSetup.CreateTestIndex(client, ElasticsearchConfiguration.DefaultIndex);
-				IntegrationSetup.CreateTestIndex(client, ElasticsearchConfiguration.DefaultIndex + "_clone");
+		var client = new ElasticClient(
+			//ElasticsearchConfiguration.Settings(hostOverride: new Uri("http://localhost:9200"))
+			ElasticsearchConfiguration.Settings()
+		);
 
-				IntegrationSetup.IndexDemoData(client);
-			}
-			catch (Exception)
-			{
-
-				throw;
-			}
+		try
+		{
+			IntegrationSetup.CreateTestIndex(client, ElasticsearchConfiguration.DefaultIndex);
+			IntegrationSetup.CreateTestIndex(client, ElasticsearchConfiguration.DefaultIndex + "_clone");
 
+			IntegrationSetup.IndexDemoData(client);
 		}
-		[TearDown]
-		public void TearDown()
+		catch (Exception)
 		{
-			var client = ElasticsearchConfiguration.Client.Value;
-			client.DeleteIndex(di => di.Indices(ElasticsearchConfiguration.DefaultIndex, ElasticsearchConfiguration.DefaultIndex + "*"));
+
+			throw;
 		}
+
 	}
+	[TearDown]
+	public void TearDown()
+	{
+		var client = ElasticsearchConfiguration.Client.Value;
+		client.DeleteIndex(di => di.Indices(ElasticsearchConfiguration.DefaultIndex, ElasticsearchConfiguration.DefaultIndex + "*"));
+	}
+}
+
 namespace Nest.Tests.Integration
 {
-	
-
 	public static class IntegrationSetup
 	{
 		public static void IndexDemoData(IElasticClient client, string index = null)
@@ -78,11 +77,11 @@ public static void CreateTestIndex(IElasticClient client, string indexName)
 				.AddMapping<ElasticsearchProject>(m => m
 					.MapFromAttributes()
 					.Properties(props => props
-						.String(s=>s
-							.Name(p=>p.Name)
-							.FieldData(fd=>fd.Loading(FieldDataLoading.Eager))
-							.Fields(fields=>fields
-								.String(ss=>ss
+						.String(s => s
+							.Name(p => p.Name)
+							.FieldData(fd => fd.Loading(FieldDataLoading.Eager))
+							.Fields(fields => fields
+								.String(ss => ss
 									.Name("sort")
 									.Index(FieldIndexOption.NotAnalyzed)
 								)
@@ -104,6 +103,6 @@ public static void CreateTestIndex(IElasticClient client, string indexName)
 			createIndexResult.IsValid.Should().BeTrue();
 		}
 
-		
+
 	}
 }

src/Tests/Nest.Tests.Integration/Nest.Tests.Integration.csproj

@@ -175,6 +175,7 @@
     <Compile Include="Indices\StatsTests.cs" />
     <Compile Include="Core\AsyncTests.cs" />
     <Compile Include="Mapping\MappingVisitorTests.cs" />
+    <Compile Include="Reproduce\Reproduce945Tests.cs" />
     <Compile Include="Reproduce\Reproduce769Tests.cs" />
     <Compile Include="Search\Filter\AndOrNotFilterTests.cs" />
     <Compile Include="Search\Filter\ScriptFilterTests.cs" />

src/Tests/Nest.Tests.Integration/Reproduce/Reproduce945Tests.cs

@@ -0,0 +1,68 @@
+using System.Text;
+using Elasticsearch.Net.ConnectionPool;
+using FluentAssertions;
+using Nest.Tests.Integration;
+using Nest.Tests.MockData;
+using Nest.Tests.MockData.Domain;
+using NUnit.Framework;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+
+namespace Nest.Tests.Integration.Reproduce
+{
+	[TestFixture]
+	public class Reproduce945Tests 
+	{
+		[Test]
+		[Ignore("Depends on setting max request size on server")]
+		public void WhenPostExceedsHttpLimit_DoNotRetry_UsingConnectionPooling()
+		{
+			var pool = new StaticConnectionPool(new []
+			{
+				new Uri("http://localhost:9200"),
+				new Uri("http://127.0.0.1:9200"),
+			});
+			var settings = new ConnectionSettings(pool);
+			var client = new ElasticClient(settings);
+
+
+			var index = ElasticsearchConfiguration.NewUniqueIndexName();
+			var projects = NestTestData.Data;
+			var people = NestTestData.People;
+			var boolTerms = NestTestData.BoolTerms;
+			var bulk = client.Bulk(b => b
+				.FixedPath(index)
+				.IndexMany(projects)
+				.IndexMany(people)
+				.IndexMany(boolTerms)
+			);
+
+			bulk.IsValid.Should().BeFalse();
+			bulk.ConnectionStatus.NumberOfRetries.Should().Be(0);
+		}
+		
+		[Test]
+		[Ignore("Depends on setting max request size on server")]
+		public void WhenPostExceedsHttpLimit_DoNotRetry_UsingPlainRetry()
+		{
+			var settings = new ConnectionSettings(new Uri("http://localhost:9200"))
+				.MaximumRetries(2);
+			var client = new ElasticClient(settings);
+
+			var index = ElasticsearchConfiguration.NewUniqueIndexName();
+			var projects = NestTestData.Data;
+			var people = NestTestData.People;
+			var boolTerms = NestTestData.BoolTerms;
+			var bulk = client.Bulk(b => b
+				.FixedPath(index)
+				.IndexMany(projects)
+				.IndexMany(people)
+				.IndexMany(boolTerms)
+			);
+
+			bulk.IsValid.Should().BeFalse();
+			bulk.ConnectionStatus.NumberOfRetries.Should().Be(0);
+		}
+	}
+}