Skip to content

Commit 1372da9

Browse files
committed
fix HttpConnectionTests backport to 2.x overriding a method that takes cancellationtoken
1 parent 202ec89 commit 1372da9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/Tests/ClientConcepts/Connection/HttpConnectionTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ public override ElasticsearchResponse<TReturn> Request<TReturn>(RequestData requ
2525
return base.Request<TReturn>(requestData);
2626
}
2727

28-
public override Task<ElasticsearchResponse<TReturn>> RequestAsync<TReturn>(RequestData requestData, CancellationToken cancellationToken)
28+
public override Task<ElasticsearchResponse<TReturn>> RequestAsync<TReturn>(RequestData requestData)
2929
{
3030
CallCount++;
31-
return base.RequestAsync<TReturn>(requestData, cancellationToken);
31+
return base.RequestAsync<TReturn>(requestData);
3232
}
3333
}
3434

@@ -42,7 +42,7 @@ public async Task SingleInstanceOfHttpClient()
4242
connection.CallCount.Should().Be(1);
4343
connection.ClientCount.Should().Be(1);
4444

45-
await connection.RequestAsync<string>(requestData, CancellationToken.None).ConfigureAwait(false);
45+
await connection.RequestAsync<string>(requestData).ConfigureAwait(false);
4646

4747
connection.CallCount.Should().Be(2);
4848
connection.ClientCount.Should().Be(1);
@@ -82,7 +82,7 @@ private static async Task MultipleInstancesOfHttpClientWhen(Func<RequestData> di
8282
connection.ClientCount.Should().Be(1);
8383

8484
requestData = differentRequestData();
85-
await connection.RequestAsync<string>(requestData, CancellationToken.None).ConfigureAwait(false);
85+
await connection.RequestAsync<string>(requestData).ConfigureAwait(false);
8686

8787
connection.CallCount.Should().Be(2);
8888
connection.ClientCount.Should().Be(2);

0 commit comments

Comments
 (0)