Shard exceptions on CCR not always immediately available (rare but does happen and makes these integration test flakey on CI

Mpdreamz · Mpdreamz · commit 3f4c70303e8c · 2019-01-28T11:24:23.000+01:00
diff --git a/src/Tests/Tests/XPack/CrossClusterReplication/CrossClusterReplicationFollowTests.cs b/src/Tests/Tests/XPack/CrossClusterReplication/CrossClusterReplicationFollowTests.cs
@@ -275,6 +275,10 @@ private static void AssertErrorsOnShardStats(FollowIndexStats[] currentIndices)
 				foreach (var s in i.Shards)
 				{
 					var because = $"index: {i.Index} shard: {s.ShardId}";
+
+					//We can call follow stats to quickly and read exceptions is not propagated yet
+					if (s.ReadExceptions.Count == 0) continue;
+
 					s.ReadExceptions.Should().NotBeEmpty(because);
 					foreach (var e in s.ReadExceptions)
 					{

Original file line number	Diff line number	Diff line change
`@@ -275,6 +275,10 @@ private static void AssertErrorsOnShardStats(FollowIndexStats[] currentIndices)`
`275`	`275`	`foreach (var s in i.Shards)`
`276`	`276`	`{`
`277`	`277`	`var because = $"index: {i.Index} shard: {s.ShardId}";`
	`278`	`+`
	`279`	`+ //We can call follow stats to quickly and read exceptions is not propagated yet`
	`280`	`+ if (s.ReadExceptions.Count == 0) continue;`
	`281`	`+`
`278`	`282`	`s.ReadExceptions.Should().NotBeEmpty(because);`
`279`	`283`	`foreach (var e in s.ReadExceptions)`
`280`	`284`	`{`