Fix #1002: GeoBoundingBox filter passing lat,lon points in the wrong order

Author: gmarz

src/Nest/DSL/Filter/FilterDescriptor.cs

@@ -165,8 +165,8 @@ public FilterContainer GeoBoundingBox(Expression<Func<T, object>> fieldDescripto
 			topLeftY.ThrowIfNull("topLeftY");
 			bottomRightX.ThrowIfNull("bottomRightX");
 			bottomRightY.ThrowIfNull("bottomRightY");
-			var geoHashTopLeft = "{0}, {1}".F(topLeftX.ToString(c), topLeftY.ToString(c));
-			var geoHashBottomRight = "{0}, {1}".F(bottomRightX.ToString(c), bottomRightY.ToString(c));
+			var geoHashTopLeft = "{0}, {1}".F(topLeftY.ToString(c), topLeftX.ToString(c));
+			var geoHashBottomRight = "{0}, {1}".F(bottomRightY.ToString(c), bottomRightX.ToString(c));
 			return this.GeoBoundingBox(fieldDescriptor, geoHashTopLeft, geoHashBottomRight, type);
 		}
 		/// <summary>
@@ -179,8 +179,8 @@ public FilterContainer GeoBoundingBox(string fieldName, double topLeftX, double
 			topLeftY.ThrowIfNull("topLeftY");
 			bottomRightX.ThrowIfNull("bottomRightX");
 			bottomRightY.ThrowIfNull("bottomRightY");
-			var geoHashTopLeft = "{0}, {1}".F(topLeftX.ToString(c), topLeftY.ToString(c));
-			var geoHashBottomRight = "{0}, {1}".F(bottomRightX.ToString(c), bottomRightY.ToString(c));
+			var geoHashTopLeft = "{0}, {1}".F(topLeftY.ToString(c), topLeftX.ToString(c));
+			var geoHashBottomRight = "{0}, {1}".F(bottomRightY.ToString(c), bottomRightX.ToString(c));
 			return this.GeoBoundingBox(fieldName, geoHashTopLeft, geoHashBottomRight, type);
 		}
 		/// <summary>

src/Tests/Nest.Tests.Unit/QueryParsers/Filter/GeoBoundingBox/Array.json

@@ -2,8 +2,8 @@
   "filter": {
     "geo_bounding_box": {
       "origin": {
-        "top_left": [0.1, 0.2],
-        "bottom_right": [0.3, 0.4]
+        "top_left": [0.2, 0.1],
+        "bottom_right": [0.4, 0.3]
       },
       "type": "memory",
       "_cache": true,

src/Tests/Nest.Tests.Unit/QueryParsers/Filter/GeoBoundingBoxFilterTests.cs

@@ -18,8 +18,8 @@ public void GeoBoundingBox_Deserializes(string cacheName, string cacheKey, bool
 
 			geoBoundingBox.Field.Should().Be("origin");
 			geoBoundingBox.GeoExecution.Should().Be(GeoExecution.Memory);
-			geoBoundingBox.TopLeft.Should().Be("0.1, 0.2");
-			geoBoundingBox.BottomRight.Should().Be("0.3, 0.4");
+			geoBoundingBox.TopLeft.Should().Be("0.2, 0.1");
+			geoBoundingBox.BottomRight.Should().Be("0.4, 0.3");
 		}
 
 		[Test]
@@ -29,8 +29,8 @@ public void GeoBoundingBox_Array_Deserializes()
 			var filter = this.ParseSearchDescriptorFromFile(f => f.GeoBoundingBox, MethodBase.GetCurrentMethod(), @"GeoBoundingBox\Array");
 			filter.Field.Should().Be("origin");
 			filter.GeoExecution.Should().Be(GeoExecution.Memory);
-			filter.TopLeft.Should().Be("0.1, 0.2");
-			filter.BottomRight.Should().Be("0.3, 0.4");
+			filter.TopLeft.Should().Be("0.2, 0.1");
+			filter.BottomRight.Should().Be("0.4, 0.3");
 		}
 
 		[Test]

src/Tests/Nest.Tests.Unit/Search/Filter/Singles/GeoBoundingBoxFilterJson.cs

@@ -21,8 +21,8 @@ public void GeoBoundingBoxFilter()
 				filter : {
 					 geo_bounding_box: {
 							origin : {
-								top_left: ""40.73, -74.1"",
-								bottom_right: ""40.717, -73.99""
+								top_left: ""-74.1, 40.73"",
+								bottom_right: ""-73.99, 40.717""
 							}
 						}
 					}
@@ -52,8 +52,8 @@ public void GeoBoundingBoxFilterCacheNamed()
 				filter : {
 					 geo_bounding_box: {
 							origin : {
-								top_left: ""40.73, -74.1"",
-								bottom_right: ""40.717, -73.99""
+								top_left: ""-74.1, 40.73"",
+								bottom_right: ""-73.99, 40.717""
 							},
 							type: ""indexed"",
 							_cache : true,