Fix warnings related to usage of deprecated string type

Author: russcam

src/Nest/Mapping/Types/Core/String/StringAttribute.cs

@@ -1,5 +1,8 @@
-namespace Nest
+using System;
+
+namespace Nest
 {
+	[Obsolete("Only valid for indices created before Elasticsearch 5.0 and will be removed in the next major version.  For newly created indices, use Text or Keyword attribute instead.")]
 	public class StringAttribute : ElasticsearchDocValuesPropertyAttributeBase, IStringProperty
 	{
 		IStringProperty Self => this;

src/Nest/Mapping/Types/PropertyJsonConverter.cs

@@ -34,7 +34,9 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
 				case "keyword":
 					return jObject.ToObject<KeywordProperty>();
 				case "string":
+#pragma warning disable 618
 					return jObject.ToObject<StringProperty>();
+#pragma warning restore 618
 				case "float":
 				case "double":
 				case "byte":

src/Nest/Mapping/Visitor/IMappingVisitor.cs

@@ -6,7 +6,9 @@ public interface IMappingVisitor
 	{
 		int Depth { get; set; }
 		void Visit(TypeMapping mapping);
+#pragma warning disable 618
 		void Visit(StringProperty property);
+#pragma warning restore 618
 		void Visit(TextProperty property);
 		void Visit(KeywordProperty property);
 		void Visit(DateProperty property);
@@ -30,8 +32,9 @@ public class NoopMappingVisitor : IMappingVisitor
 
 		public virtual void Visit(TypeMapping mapping) { }
 
+#pragma warning disable 618
 		public virtual void Visit(StringProperty property ) { }
-
+#pragma warning restore 618
 		public virtual void Visit(TextProperty property) { }
 
 		public virtual void Visit(KeywordProperty property) { }

src/Nest/Mapping/Visitor/IPropertyVisitor.cs

@@ -4,7 +4,9 @@ namespace Nest
 {
 	public interface IPropertyVisitor
 	{
+#pragma warning disable 618
 		void Visit(IStringProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
+#pragma warning restore 618
 		void Visit(ITextProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
 		void Visit(IKeywordProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
 		void Visit(INumberProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);

src/Nest/Mapping/Visitor/MappingWalker.cs

@@ -48,7 +48,9 @@ public void Accept(IProperties properties)
 						this.Accept(k.Fields);
 						break;
 					case "string":
+#pragma warning disable 618
 						var s = field as StringProperty;
+#pragma warning restore 618
 						if (s == null) continue;
 						this._visitor.Visit(s);
 						this.Accept(s.Fields);

src/Nest/Mapping/Visitor/NoopPropertyVisitor.cs

@@ -63,9 +63,12 @@ public virtual void Visit(ITextProperty type, PropertyInfo propertyInfo, Elastic
 		public virtual void Visit(IKeywordProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute)
 		{
 		}
+
+#pragma warning disable 618
 		public virtual void Visit(IStringProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute)
 		{
 		}
+#pragma warning restore 618
 
 		public virtual IProperty Visit(PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute) => null;
 

src/Tests/Document/Multiple/UpdateByQuery/UpdateByQueryApiTests.cs

@@ -28,6 +28,7 @@ protected override void IntegrationSetup(IElasticClient client, CallUniqueValues
 		{
 			foreach (var index in values.Values)
 			{
+#pragma warning disable 618
 				this.Client.CreateIndex(index, c => c
 					.Mappings(m => m
 						.Map<Test>(map => map
@@ -38,6 +39,7 @@ protected override void IntegrationSetup(IElasticClient client, CallUniqueValues
 						)
 					)
 				);
+#pragma warning restore 618
 				this.Client.Index(new Test { Text = "words words", Flag = "bar" }, i=>i.Index(index).Refresh());
 				this.Client.Index(new Test { Text = "words words", Flag = "foo" }, i=>i.Index(index).Refresh());
 				this.Client.Map<Test>(m => m

src/Tests/Document/Single/Index/IndexIngestAttachmentApiTests.cs

@@ -42,7 +42,7 @@ protected override void IntegrationSetup(IElasticClient client, CallUniqueValues
 					.Mappings(m => m
 						.Map<IngestedAttachment>(mm => mm
 							.Properties(p => p
-								.String(s => s
+								.Text(s => s
 									.Name(f => f.Content)
 								)
 								.Object<Nest.Attachment>(o => o

src/Tests/Indices/MappingManagement/GetMapping/GetMappingApiTest.cs

@@ -82,11 +82,12 @@ public void CountsShouldContainKeyAndCountBe(string key, int count)
 			this.Counts[key].Should().Be(count);
 		}
 
+#pragma warning disable 618
 		public void Visit(StringProperty mapping)
 		{
 			Increment("string");
 		}
-
+#pragma warning restore 618
 		public void Visit(DateProperty mapping)
 		{
 			Increment("date");

src/Tests/Mapping/Types/Core/String/StringMappingTests.cs

@@ -1,6 +1,7 @@
 using System;
 using Nest;
 
+#pragma warning disable 618
 namespace Tests.Mapping.Types.Core.String
 {
 	public class StringTest
@@ -133,3 +134,4 @@ public class StringMappingTests : TypeMappingTestBase<StringTest>
 			);
 	}
 }
+#pragma warning restore 618