Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
{
"inference.put_openshift_ai": {
"documentation": {
"url": "https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-inference-put-openshift-ai",
"description": "Create an OpenShift AI inference endpoint"
},
"stability": "stable",
"visibility": "public",
"headers": {
"accept": ["application/json"],
"content_type": ["application/json"]
},
"url": {
"paths": [
{
"path": "/_inference/{task_type}/{openshiftai_inference_id}",
"methods": ["PUT"],
"parts": {
"task_type": {
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "enum"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time this PR was opened, task_type was still defined as a string in every other place. It was converted to an enum in other parts of the codebase during the time this PR was awaiting review. I’ve updated this PR accordingly to align with the latest changes. Thanks.

"description": "The task type"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the "type" and "description" fields, I think there should be an "options" one listing the valid values for "task_type" for this integration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here. It was added in other parts of the codebase during the time this PR was awaiting review. I’ve updated this PR accordingly to align with the latest changes. Thanks.

},
"openshiftai_inference_id": {
"type": "string",
"description": "The inference ID"
}
}
}
]
},
"body": {
"description": "The inference endpoint's task and service settings",
"required": true
},
"params": {
"timeout": {
"type": "time",
"description": "Specifies the amount of time to wait for the inference endpoint to be created.",
"default": "30s"
}
}
}
}