Skip to content

Commit 97051ae

Browse files
authored
Ask for visibility if group is platform (#242398)
## Summary We were defaulting visibility to `private` if group not provided as cli `--group` flag. This is incorrect, since users can still choose `platform` group, and in that case we need to ask for desired visibility.
1 parent 58167a0 commit 97051ae

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/kbn-generate/src/commands/package_command.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,6 @@ export const PackageCommand: GenerateCommand = {
9595
let group = flags.group as KibanaGroup | undefined;
9696
let visibility = flags.visibility as 'private' | 'shared' | undefined;
9797

98-
if (group !== 'platform') {
99-
visibility = 'private';
100-
}
101-
10298
const license = flags.license as 'oss' | 'x-pack' | undefined;
10399
let calculatedPackageDir: string;
104100

@@ -157,6 +153,10 @@ export const PackageCommand: GenerateCommand = {
157153
})
158154
).group;
159155

156+
if (group !== 'platform') {
157+
visibility = 'private';
158+
}
159+
160160
let xpack: boolean;
161161

162162
if (!!license) {

0 commit comments

Comments
 (0)