Fix ID consistency and generate documentation

Co-authored-by: tobio <444668+tobio@users.noreply.github.com>

Author: Copilot

docs/resources/kibana_default_data_view.md

@@ -0,0 +1,29 @@
+---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "elasticstack_kibana_default_data_view Resource - terraform-provider-elasticstack"
+subcategory: "Kibana"
+description: |-
+  Manages the default Kibana data view. See the Kibana Data Views API documentation https://www.elastic.co/docs/api/doc/kibana/v8/operation/operation-setdefaultdatailviewdefault for more information.
+---
+
+# elasticstack_kibana_default_data_view (Resource)
+
+Manages the default Kibana data view. See the [Kibana Data Views API documentation](https://www.elastic.co/docs/api/doc/kibana/v8/operation/operation-setdefaultdatailviewdefault) for more information.
+
+
+
+<!-- schema generated by tfplugindocs -->
+## Schema
+
+### Required
+
+- `data_view_id` (String) The data view identifier to set as default. NOTE: The API does not validate whether it is a valid identifier. Use `null` to unset the default data view.
+
+### Optional
+
+- `force` (Boolean) Update an existing default data view identifier. If set to false and a default data view already exists, the operation will fail.
+- `skip_delete` (Boolean) If set to true, the default data view will not be unset when the resource is destroyed. The existing default data view will remain unchanged.
+
+### Read-Only
+
+- `id` (String) Internal identifier of the resource.

internal/kibana/default_data_view/create.go

@@ -2,7 +2,6 @@ package default_data_view
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/elastic/terraform-provider-elasticstack/generated/kbapi"
 	"github.com/elastic/terraform-provider-elasticstack/internal/clients/kibana_oapi"
@@ -38,8 +37,8 @@ func (r *DefaultDataViewResource) Create(ctx context.Context, req resource.Creat
 		return
 	}
 
-	// Set the ID to the data view ID for state tracking
-	plan.ID = types.StringValue(fmt.Sprintf("default-data-view:%s", dataViewID))
+	// Set a static ID since there's only one default data view setting
+	plan.ID = types.StringValue("default")
 
 	diags = resp.State.Set(ctx, plan)
 	resp.Diagnostics.Append(diags...)

internal/kibana/default_data_view/read.go

@@ -2,7 +2,6 @@ package default_data_view
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/elastic/terraform-provider-elasticstack/internal/clients/kibana_oapi"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
@@ -37,7 +36,10 @@ func (r *DefaultDataViewResource) Read(ctx context.Context, req resource.ReadReq
 
 	// Update state with current default data view
 	state.DataViewID = types.StringValue(*defaultDataViewID)
-	state.ID = types.StringValue(fmt.Sprintf("default-data-view:%s", *defaultDataViewID))
+	// Keep the ID as "default" - it should remain static
+	if state.ID.IsNull() || state.ID.IsUnknown() {
+		state.ID = types.StringValue("default")
+	}
 
 	diags = resp.State.Set(ctx, state)
 	resp.Diagnostics.Append(diags...)

internal/kibana/default_data_view/update.go

@@ -2,7 +2,6 @@ package default_data_view
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/elastic/terraform-provider-elasticstack/generated/kbapi"
 	"github.com/elastic/terraform-provider-elasticstack/internal/clients/kibana_oapi"
@@ -38,8 +37,8 @@ func (r *DefaultDataViewResource) Update(ctx context.Context, req resource.Updat
 		return
 	}
 
-	// Update the ID to reflect the new data view ID
-	plan.ID = types.StringValue(fmt.Sprintf("default-data-view:%s", dataViewID))
+	// Keep the ID as "default" - it should remain static
+	plan.ID = types.StringValue("default")
 
 	diags = resp.State.Set(ctx, plan)
 	resp.Diagnostics.Append(diags...)