Skip to content

Commit 05fed5c

Browse files
committed
Cannot parse given Error object
1 parent 7f9cabb commit 05fed5c

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

dist/elmahio.js

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/elmahio.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/elmahio.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/elmahio.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/elmahio.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,7 +1175,7 @@
11751175

11761176
if (type !== "Log") {
11771177

1178-
var stack = error ? ErrorStackParser.parse(error) : null;
1178+
var stack = error && error instanceof Error ? ErrorStackParser.parse(error) : null;
11791179

11801180
var jsonData = {
11811181
"title": message,
@@ -1225,16 +1225,17 @@
12251225
// on message event
12261226
publicAPIs.emit('message', jsonData);
12271227

1228-
if (error && type !== "Log" && typeof Promise !== "undefined" && Promise.toString().indexOf("[native code]") !== -1) {
1228+
if (error && error instanceof Error && type !== "Log" && typeof Promise !== "undefined" && Promise.toString().indexOf("[native code]") !== -1) {
12291229
// send message trying to pinpoint stackframes
12301230
stackGPS(error, xhr, jsonData);
12311231
} else {
12321232
// send message
1233-
if(jsonData.errorObject) {
1233+
if(jsonData.errorObject && jsonData.errorObject instanceof Error) {
12341234
error = jsonData.errorObject;
12351235
delete jsonData.errorObject;
12361236
stackGPS(error, xhr, jsonData);
12371237
} else {
1238+
delete jsonData.errorObject;
12381239
xhr.send(JSON.stringify(jsonData));
12391240
}
12401241
}

0 commit comments

Comments
 (0)