Go to the version index when changing ember-data versions across the 4.0

boundary

4.0 is somewhat arbitrarily chosen as a spot where ember-data is
substantially different organization before and after.

Author: kategengler

app/controllers/project-version.js

@@ -189,30 +189,36 @@ export function findEndingRoute({
       break;
   }
 
-  let isEmberProject = project === 'ember';
-
-  // if the user is navigating to/from api versions >= 2.16, take them
+  // if the user is navigating to/from api versions Ember >= 2.16 or Ember Data >= 4.0, take them
   // to the home page instead of trying to translate the url
-  let shouldConvertPackages = _shouldConvertPackages(
+  if (shouldGoToVersionIndex(project, targetVersion, currentVersion)) {
+    return `/${project}/${projectVersionID}`;
+  } else {
+    return `/${project}/${projectVersionID}/${endingRoute}${currentAnchor}`;
+  }
+}
+
+function shouldGoToVersionIndex(project, targetVersion, currentVersion) {
+  let boundaryVersion;
+  if (project === 'ember') {
+    boundaryVersion = '2.16';
+  } else if (project === 'ember-data') {
+    boundaryVersion = '4.0';
+  }
+  return isCrossingVersionBoundary(
     targetVersion,
     currentVersion,
+    boundaryVersion,
   );
-
-  if (!isEmberProject || !shouldConvertPackages) {
-    return `/${project}/${projectVersionID}/${endingRoute}${currentAnchor}`;
-  } else {
-    return `/${project}/${projectVersionID}`;
-  }
 }
 
 // Input some version info, returns a boolean based on
-// whether the user is switching versions for a 2.16 docs release or later.
-// The urls for pre-2.16 classes and later packages are quite different
-function _shouldConvertPackages(targetVer, previousVer) {
+// whether the user is switching versions for a release or later.
+function isCrossingVersionBoundary(targetVer, previousVer, boundaryVersion) {
   let targetVersion = getCompactVersion(targetVer);
   let previousVersion = getCompactVersion(previousVer);
-  let previousComparison = semverCompare(previousVersion, '2.16');
-  let targetComparison = semverCompare(targetVersion, '2.16');
+  let previousComparison = semverCompare(previousVersion, boundaryVersion);
+  let targetComparison = semverCompare(targetVersion, boundaryVersion);
   return (
     (previousComparison < 0 && targetComparison >= 0) ||
     (previousComparison >= 0 && targetComparison < 0)

tests/unit/controllers/project-version-test.js

@@ -81,5 +81,61 @@ module('Unit | Controller | project version', function (hooks) {
         '/ember/6.4/modules/%40ember%2Fapplication#classes',
       );
     });
+
+    test('For ember project, it goes to version root when crossing 2.16 boundary', function (assert) {
+      let endingRoute = findEndingRoute({
+        project: 'ember',
+        targetVersion: '2.15.0',
+        currentVersion: '2.16.0',
+        currentRouteName: 'project-version.classes.class',
+        classModelName: 'Component',
+        moduleModelName: null,
+        namespaceModelName: null,
+        currentAnchor: '#didInsertElement',
+      });
+
+      assert.strictEqual(endingRoute, '/ember/2.15');
+
+      endingRoute = findEndingRoute({
+        project: 'ember',
+        targetVersion: '2.16.0',
+        currentVersion: '2.15.0',
+        currentRouteName: 'project-version.classes.class',
+        classModelName: 'Component',
+        moduleModelName: null,
+        namespaceModelName: null,
+        currentAnchor: '#didInsertElement',
+      });
+
+      assert.strictEqual(endingRoute, '/ember/2.16');
+    });
+
+    test('For ember-data project, it goes to version root when crossing 4.0 boundary', function (assert) {
+      let endingRoute = findEndingRoute({
+        project: 'ember-data',
+        targetVersion: '3.28.0',
+        currentVersion: '4.0.0',
+        currentRouteName: 'project-version.classes.class',
+        classModelName: 'Adapter',
+        moduleModelName: null,
+        namespaceModelName: null,
+        currentAnchor: '',
+      });
+
+      assert.strictEqual(endingRoute, '/ember-data/3.28');
+
+      endingRoute = findEndingRoute({
+        project: 'ember-data',
+        targetVersion: '4.0.0',
+        currentVersion: '3.28.0',
+        currentRouteName: 'project-version.classes.class',
+        classModelName: 'DS.Adapter',
+        moduleModelName: null,
+        namespaceModelName: null,
+        currentAnchor: '',
+      });
+
+      assert.strictEqual(endingRoute, '/ember-data/4.0');
+    });
   });
 });