Skip to content

Commit 944d194

Browse files
ming-codessamselikoff
authored andcommitted
Fix resolved type on module name containing type itself (#331)
1 parent c3bcab0 commit 944d194

File tree

2 files changed

+23
-3
lines changed

2 files changed

+23
-3
lines changed

lib/broccoli/docs-compiler/navigation-index-generator.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ module.exports = class NavigationIndexGenerator {
5353
}
5454

5555
_resolvedTypeForModule(module) {
56-
return RESOLVED_TYPES.find(type => {
57-
return module.file.match(`${type}/`) && !module.file.match('utils/');
58-
});
56+
let [ , type ] = module.file.split('/');
57+
58+
return RESOLVED_TYPES.includes(type) && type;
5959
}
6060

6161
_isResolvedType(module) {

tests-node/unit/navigation-index-generator/test.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,4 +228,24 @@ QUnit.module('Unit | NavigationIndexGenerator', function(hooks) {
228228
]);
229229
});
230230

231+
test('correctly handle _resolvedTypeForModule for module names containing type itself', function(assert) {
232+
let testcases = [
233+
[ 'ember-addon-helpers/unresolved-type', false ],
234+
[ 'ember-addon-helpers/helpers', 'helpers' ],
235+
[ 'ember-addon-components/helpers', 'helpers' ],
236+
[ 'ember-addon-components/controllers', 'controllers' ],
237+
[ 'ember-addon-services/controllers', 'controllers' ],
238+
[ 'ember-addon-services/services', 'services' ],
239+
[ 'ember-addon-services/helpers', 'helpers' ],
240+
[ 'ember-addon-services', false ]
241+
];
242+
243+
testcases.forEach(([ testcase, expected ]) => {
244+
let type = generator._resolvedTypeForModule({
245+
file: testcase
246+
});
247+
248+
assert.equal(type, expected);
249+
})
250+
});
231251
});

0 commit comments

Comments
 (0)