Merge pull request #145 from ember-learn/support-ember-2-8

Add Ember 2.8 to ember-try config

Author: samselikoff

.travis.yml

@@ -58,7 +58,8 @@ jobs:
       script: yarn test:node
 
     - stage: versioned tests
-      env: EMBER_TRY_SCENARIO=ember-lts-2.12
+      env: EMBER_TRY_SCENARIO=ember-lts-2.8
+    - env: EMBER_TRY_SCENARIO=ember-lts-2.12
     - env: EMBER_TRY_SCENARIO=ember-lts-2.16
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta

addon/components/docs-viewer/x-nav/template.hbs

@@ -7,7 +7,7 @@
   </div>
 {{/if}}
 
-<nav {{action (mut isShowingMenu) false}}
+<nav onclick={{action (mut isShowingMenu) false}}
   class='
     absolute pin-r lg:relative bg-white shadow-lg lg:shadow-none
     w-90% px-3 lg:px-0 z-10 lg:w-1/5 flex-no-shrink transition
@@ -20,7 +20,7 @@
   <div class='pt-px sticky pin-t mb-8 '>
     {{#if (or media.isMobile media.isTablet)}}
       <div class="text-right">
-        <button {{action (mut isShowingMenu) false}}
+        <button onclick={{action (mut isShowingMenu) false}}
           class='text-grey-darkest opacity-50 hover:opacity-100 text-3xl py-2 no-underline'>
           &times;
         </button>

config/ember-try.js

@@ -15,6 +15,17 @@ module.exports = function() {
           name: 'node',
           command: 'yarn test:node'
         },
+        {
+          name: 'ember-lts-2.8',
+          bower: {
+            dependencies: {
+              'ember': 'components/ember#lts-2-8'
+            },
+            resolutions: {
+              'ember': 'lts-2-8'
+            }
+          },
+        },
         {
           name: 'ember-lts-2.12',
           npm: {