Skip to content

Commit c212bf7

Browse files
alexlafrosciasamselikoff
authored andcommitted
Avoid using an <a> without navigation (#129)
1 parent 116f79a commit c212bf7

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

addon/components/docs-demo/template.hbs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,15 @@
99
{{#if snippets}}
1010
<nav class="docs-demo__snippets-nav py-2 px-4 font-medium bg-grey-lighter tracking-tight">
1111
{{#each snippets as |snippet|}}
12-
<a href='#' {{action 'selectSnippet' snippet}}
12+
<button {{action 'selectSnippet' snippet}}
1313
class='
14-
docs-demo__snippets-nav-item
15-
mr-4 text-sm no-underline
14+
mr-4 text-sm no-underline outline-none
1615
hover:text-grey-darkest
1716
{{if snippet.isActive 'text-grey-darkest' 'text-grey-dark'}}
1817
'
1918
>
2019
{{snippet.label}}
21-
</a>
20+
</button>
2221
{{/each}}
2322
</nav>
2423
{{/if}}

addon/tailwind/config/modules.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ pre {
139139
.overflow-momentum {
140140
-webkit-overflow-scrolling: touch;
141141
}
142-
.outline-none {
142+
.outline-none,
143+
.outline-none:focus {
143144
outline: none;
144145
}

0 commit comments

Comments
 (0)