Skip to content

Commit e33a497

Browse files
authored
fix deprecation computed-property.override by adding setters (#451)
see https://emberjs.com/deprecations/v3.x#toc_computed-property-override
1 parent ba284dc commit e33a497

File tree

2 files changed

+29
-18
lines changed

2 files changed

+29
-18
lines changed

addon/components/docs-viewer/x-nav/component.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,13 @@ export default Component.extend({
2727
/*
2828
This is overwritten for the Sandbox.
2929
*/
30-
project: computed(function() {
31-
return this.get('store').peekRecord('project', projectName);
30+
project: computed({
31+
get() {
32+
return this.get('store').peekRecord('project', projectName);
33+
},
34+
35+
set(key, val) {
36+
return val;
37+
}
3238
})
3339
});

addon/services/project-version.js

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,22 +42,27 @@ export default Service.extend({
4242
return rootURL.replace(`/${this.get('currentVersion.path')}/`, '/');
4343
}),
4444

45-
currentVersion: computed(function() {
46-
let config = getOwner(this).resolveRegistration('config:environment')['ember-cli-addon-docs'];
47-
let currentVersion = config.deployVersion;
48-
49-
// In development, this token won't have been replaced replaced
50-
if (currentVersion === 'ADDON_DOCS_DEPLOY_VERSION') {
51-
currentVersion = {
52-
key: latestVersionName,
53-
name: latestVersionName,
54-
tag: config.projectTag,
55-
path: '',
56-
sha: 'abcde'
57-
};
58-
}
45+
currentVersion: computed({
46+
get() {
47+
let config = getOwner(this).resolveRegistration('config:environment')['ember-cli-addon-docs'];
48+
let currentVersion = config.deployVersion;
5949

60-
return currentVersion;
61-
})
50+
// In development, this token won't have been replaced replaced
51+
if (currentVersion === 'ADDON_DOCS_DEPLOY_VERSION') {
52+
currentVersion = {
53+
key: latestVersionName,
54+
name: latestVersionName,
55+
tag: config.projectTag,
56+
path: '',
57+
sha: 'abcde'
58+
};
59+
}
60+
61+
return currentVersion;
62+
},
6263

64+
set(key, val) {
65+
return val;
66+
}
67+
})
6368
});

0 commit comments

Comments
 (0)