Skip to content

Commit 0847c3f

Browse files
committed
comments
1 parent be10d98 commit 0847c3f

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/lib/libemval.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,7 @@ ${functionBody}
409409
return Emval.toHandle(value);
410410
});
411411
},
412-
#endif
413-
#if ASYNCIFY == 2
412+
#else
414413
_emval_await: async (promise) => {
415414
var value = await Emval.toValue(promise);
416415
return Emval.toHandle(value);

test/test_other.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3254,11 +3254,11 @@ def test_embind_asyncify(self):
32543254
''')
32553255
self.do_runf('main.cpp', 'done', cflags=['-lembind', '-sASYNCIFY', '--post-js', 'post.js'])
32563256

3257+
@also_with_wasm64
32573258
@parameterized({
3258-
'': [['-sDYNAMIC_EXECUTION=1']],
3259-
'no_dynamic': [['-sDYNAMIC_EXECUTION=0']],
3260-
'dyncall': [['-sALLOW_MEMORY_GROWTH', '-sMAXIMUM_MEMORY=4GB']],
3261-
'wasm64': (['-sMEMORY64'],),
3259+
'': (['-sDYNAMIC_EXECUTION=1'],),
3260+
'no_dynamic': (['-sDYNAMIC_EXECUTION=0'],),
3261+
'dyncall': (['-sALLOW_MEMORY_GROWTH', '-sMAXIMUM_MEMORY=4GB'],),
32623262
})
32633263
@requires_jspi
32643264
def test_embind_jspi(self, args):
@@ -3512,8 +3512,8 @@ def test_jspi_bad_library_function(self):
35123512
foo();
35133513
}
35143514
''')
3515-
err = self.expect_fail([EMCC, 'main.c', '-o', 'out.js', '-sJSPI', '--js-library=lib.js', '-Wno-experimental',])
3516-
self.assertContained('error: foo is marked with the __async decorator but is not an async JS function.', err)
3515+
err = self.expect_fail([EMCC, 'main.c', '-o', 'out.js', '-sJSPI', '--js-library=lib.js', '-Wno-experimental'])
3516+
self.assertContained('error: \'foo\' is marked with the __async decorator but is not an async JS function.', err)
35173517

35183518
@requires_dev_dependency('typescript')
35193519
@parameterized({

0 commit comments

Comments
 (0)