Commit 5e9bc54
authored
Explain why not using inet_pton for IPv6 addresses (#39686)
Commit Message: Explain why not using inet_pton for IPv6 addresses
Additional Description: It took me a while to figure out why we're using
the much more complicated and less performant `getaddrinfo()` for
`parseV6Address`, rather than `inet_pton`, which google searches
generally recommend using. Even the discussion history on the
responsible commits didn't really clarify, and `scope` as an explanation
was insufficient because the word is way too overloaded. This PR adds a
couple of lines of comments that make the reason for this choice clear
for the next confused person.
Risk Level: None, change is comment-only.
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Signed-off-by: Raven Black <ravenblack@dropbox.com>1 parent cde9aeb commit 5e9bc54
1 file changed
+2
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| 122 | + | |
| 123 | + | |
122 | 124 | | |
123 | 125 | | |
124 | 126 | | |
| |||
0 commit comments