refactor(ble): Pass pointer to const data to setValue()

There is no technical need to pass non-const data there.

Also it is a common practice to pass const data to the functions
with write semantics, as they not supposed to modify the data.

This allows to pass the data from read-only sources without
removing the constness what is not always safe.

Author: Kolcha

libraries/BLE/src/BLECharacteristic.cpp

@@ -346,7 +346,7 @@ void BLECharacteristic::setReadProperty(bool value) {
  * @param [in] data The data to set for the characteristic.
  * @param [in] length The length of the data in bytes.
  */
-void BLECharacteristic::setValue(uint8_t *data, size_t length) {
+void BLECharacteristic::setValue(const uint8_t *data, size_t length) {
 // The call to BLEUtils::buildHexData() doesn't output anything if the log level is not
 // "VERBOSE". As it is quite CPU intensive, it is much better to not call it if not needed.
 #if ARDUHAL_LOG_LEVEL >= ARDUHAL_LOG_LEVEL_VERBOSE

libraries/BLE/src/BLECharacteristic.h

@@ -184,7 +184,7 @@ class BLECharacteristic {
   void indicate();
   void notify(bool is_notification = true);
   void setCallbacks(BLECharacteristicCallbacks *pCallbacks);
-  void setValue(uint8_t *data, size_t size);
+  void setValue(const uint8_t *data, size_t size);
   void setValue(String value);
   void setValue(uint16_t data16);
   void setValue(uint32_t data32);

libraries/BLE/src/BLEDescriptor.cpp

@@ -181,7 +181,7 @@ void BLEDescriptor::setHandle(uint16_t handle) {
  * @param [in] data The data to set for the descriptor.
  * @param [in] length The length of the data in bytes.
  */
-void BLEDescriptor::setValue(uint8_t *data, size_t length) {
+void BLEDescriptor::setValue(const uint8_t *data, size_t length) {
   if (length > m_value.attr_max_len) {
     log_e("Size %d too large, must be no bigger than %d", length, m_value.attr_max_len);
     return;

libraries/BLE/src/BLEDescriptor.h

@@ -94,7 +94,7 @@ class BLEDescriptor {
 
   void setAccessPermissions(uint8_t perm);                // Set the permissions of the descriptor.
   void setCallbacks(BLEDescriptorCallbacks *pCallbacks);  // Set callbacks to be invoked for the descriptor.
-  void setValue(uint8_t *data, size_t size);              // Set the value of the descriptor as a pointer to data.
+  void setValue(const uint8_t *data, size_t size);        // Set the value of the descriptor as a pointer to data.
   void setValue(String value);                            // Set the value of the descriptor as a data buffer.
 
   String toString();  // Convert the descriptor to a string representation.

libraries/BLE/src/BLEValue.cpp

@@ -48,7 +48,7 @@ void BLEValue::addPart(String part) {
  * @param [in] pData A message part being added.
  * @param [in] length The number of bytes being added.
  */
-void BLEValue::addPart(uint8_t *pData, size_t length) {
+void BLEValue::addPart(const uint8_t *pData, size_t length) {
   log_v(">> addPart: length=%d", length);
   m_accumulation += String((char *)pData, length);
 }  // addPart
@@ -130,7 +130,7 @@ void BLEValue::setValue(String value) {
  * @param [in] pData The data for the current value.
  * @param [in] The length of the new current value.
  */
-void BLEValue::setValue(uint8_t *pData, size_t length) {
+void BLEValue::setValue(const uint8_t *pData, size_t length) {
   m_value = String((char *)pData, length);
 }  // setValue
 

libraries/BLE/src/BLEValue.h

@@ -35,7 +35,7 @@ class BLEValue {
 
   BLEValue();
   void addPart(String part);
-  void addPart(uint8_t *pData, size_t length);
+  void addPart(const uint8_t *pData, size_t length);
   void cancel();
   void commit();
   uint8_t *getData();
@@ -44,7 +44,7 @@ class BLEValue {
   String getValue();
   void setReadOffset(uint16_t readOffset);
   void setValue(String value);
-  void setValue(uint8_t *pData, size_t length);
+  void setValue(const uint8_t *pData, size_t length);
 
 private:
   /***************************************************************************