Commit 0c0b384
committed
fix: Address review comments for UseUserAccessGroup
This commit incorporates feedback for the `UseUserAccessGroup` method:
- Stub implementations for Android and desktop now return
`kAuthErrorUnimplemented` instead of `kAuthErrorNone`.
- The iOS implementation now returns `kAuthErrorUninitialized`
if `auth_data_` is null.
- The iOS implementation now treats an empty string for `access_group`
the same as `nullptr` (passing `nil` to the Objective-C method).1 parent a4b656f commit 0c0b384
File tree
3 files changed
+6
-6
lines changed- auth/src
- android
- desktop
- ios
3 files changed
+6
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
671 | 671 | | |
672 | 672 | | |
673 | 673 | | |
674 | | - | |
675 | | - | |
| 674 | + | |
| 675 | + | |
676 | 676 | | |
677 | 677 | | |
678 | 678 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
576 | 576 | | |
577 | 577 | | |
578 | 578 | | |
579 | | - | |
580 | | - | |
| 579 | + | |
| 580 | + | |
581 | 581 | | |
582 | 582 | | |
583 | 583 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
592 | 592 | | |
593 | 593 | | |
594 | 594 | | |
595 | | - | |
| 595 | + | |
596 | 596 | | |
597 | 597 | | |
598 | 598 | | |
599 | | - | |
| 599 | + | |
600 | 600 | | |
601 | 601 | | |
602 | 602 | | |
| |||
0 commit comments