Skip to content

Commit 1e3d71c

Browse files
committed
Fix formatting and comments
1 parent 3250ce4 commit 1e3d71c

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

analytics/integration_test/src/integration_test.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,20 +256,18 @@ TEST_F(FirebaseAnalyticsTest, TestSetLogCallback) {
256256
finishedPromise.set_value();
257257
});
258258

259-
// Trigger the event
260259
const firebase::analytics::Parameter kInvalidParameters[] = {
261260
firebase::analytics::Parameter("invalid_character_!", 5),
262261
};
263262
firebase::analytics::LogEvent(
264263
"invalid_event", kInvalidParameters,
265264
sizeof(kInvalidParameters) / sizeof(kInvalidParameters[0]));
266265

267-
// Idiomatic Timeout Handling
268266
if (finished.wait_for(std::chrono::seconds(5)) ==
269267
std::future_status::timeout) {
270268
ADD_FAILURE() << "Timed out waiting for log callback";
271269
} else {
272-
finished.get(); // Synchronizes threads and propagates any exceptions
270+
finished.get();
273271
}
274272

275273
EXPECT_TRUE(log_callback_called);

0 commit comments

Comments
 (0)