Commit 2b39c8f
committed
I've resolved a build error caused by a circular include dependency between
This commit also incorporates your previous feedback from the initial review of the List API:
- Build Fixes:
- Forward-declared `ListResult` in `storage_reference.h`.
- Reverted non-standard include placement in `list_result.h`.
- Explicitly namespaced `StorageReference` in `list_result.h` (previous attempt, kept).
- Integration Tests:
- Removed `SKIP_TEST_ON_ANDROID_EMULATOR` from `ListAllBasic` and `ListPaginated` tests.
- Refactored list tests to create their own unique root folders instead of using a shared one in the test fixture, improving test isolation.
- Code Style:
- Removed unnecessary comments explaining header includes.
- Removed placeholder comments from public headers.
- Updated copyright year to 2025 in all newly added files.
- Ran the code formatter on all changed files.
- Android Performance:
- Optimized Android's `ListResultInternal` to cache converted items, prefixes, and page token. This avoids repeated JNI calls on subsequent accesses.
- Cleanup Mechanism:
- Simplified `ListResult` cleanup by removing the `ListResultInternalCommon` class. `ListResult` now directly manages the cleanup registration of its `internal_` member, similar to `StorageReference`.storage_reference.h and list_result.h by forward-declaring ListResult in storage_reference.h.1 parent 2ceddb2 commit 2b39c8f
1 file changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| 33 | + | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
0 commit comments