refactor: Correct StorageInternal includes and finalize feedback

Corrects include directives for platform-specific StorageInternal
definitions in list_result_android.h, list_result_ios.h, and
list_result_desktop.h. Removes includes for the deleted
ListResultInternalCommon class.

This commit also incorporates previous feedback and build fixes:

- Build Fixes:
    - Resolved circular include dependency between storage_reference.h and
      list_result.h by forward-declaring ListResult in storage_reference.h.
    - Corrected includes in list_result.cc and platform-specific
      list_result_*.h files to use appropriate platform-specific
      headers for StorageInternal definitions.
- Integration Tests:
    - Removed SKIP_TEST_ON_ANDROID_EMULATOR from ListAllBasic and ListPaginated tests.
    - Refactored list tests to create their own unique root folders.
- Code Style:
    - Removed unnecessary comments.
    - Updated copyright years to 2025.
    - Ran code formatter on all changed files.
- Android Performance:
    - Optimized Android's ListResultInternal to cache converted data.
- Cleanup Mechanism:
    - Simplified ListResult cleanup logic.

Author: google-labs-jules[bot]

storage/src/android/list_result_android.h

@@ -23,10 +23,9 @@
 #include "app/src/util_android.h"
 #include "firebase/app.h"
 #include "firebase/storage/storage_reference.h"
-#include "storage/src/common/storage_internal.h"
-// It's okay for platform specific internal headers to include common internal
-// headers.
-#include "storage/src/common/list_result_internal_common.h"
+// #include "storage/src/common/storage_internal.h" // Removed
+#include "storage/src/android/storage_android.h"  // Added for Android StorageInternal
+// #include "storage/src/common/list_result_internal_common.h" // Removed
 
 namespace firebase {
 namespace storage {
@@ -36,9 +35,8 @@ class ListResult;
 
 namespace internal {
 
-// Declare ListResultInternal a friend of ListResultInternalCommon for
 // construction.
-class ListResultInternalCommon;
+// class ListResultInternalCommon; // Removed
 
 // Contains the Android-specific implementation of ListResultInternal.
 class ListResultInternal {
@@ -83,7 +81,7 @@ class ListResultInternal {
   friend class firebase::storage::ListResult;
   // For ListResultInternalCommon's constructor and access to app_ via
   // storage_internal().
-  friend class ListResultInternalCommon;
+  // friend class ListResultInternalCommon; // Removed as class is removed
 
   // Converts a Java List of Java StorageReference objects to a C++ vector of
   // C++ StorageReference objects.

storage/src/desktop/list_result_desktop.cc

@@ -1,4 +1,4 @@
-// Copyright 2021 Google LLC
+// Copyright 2025 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

storage/src/desktop/list_result_desktop.h

@@ -1,4 +1,4 @@
-// Copyright 2021 Google LLC
+// Copyright 2025 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -19,10 +19,9 @@
 #include <vector>
 
 #include "firebase/storage/storage_reference.h"
-#include "storage/src/common/storage_internal.h"
-// It's okay for platform specific internal headers to include common internal
-// headers.
-#include "storage/src/common/list_result_internal_common.h"
+// #include "storage/src/common/storage_internal.h" // Removed
+#include "storage/src/desktop/storage_desktop.h"  // Added for Desktop StorageInternal
+// #include "storage/src/common/list_result_internal_common.h" // Removed
 
 namespace firebase {
 namespace storage {
@@ -34,7 +33,7 @@ namespace internal {
 
 // Declare ListResultInternal a friend of ListResultInternalCommon for
 // construction.
-class ListResultInternalCommon;
+// class ListResultInternalCommon; // Removed
 
 // Contains the Desktop-specific implementation of ListResultInternal (stubs).
 class ListResultInternal {
@@ -77,7 +76,7 @@ class ListResultInternal {
   friend class firebase::storage::ListResult;
   // For ListResultInternalCommon's constructor and access to app_ via
   // storage_internal().
-  friend class ListResultInternalCommon;
+  // friend class ListResultInternalCommon; // Removed
 
   StorageInternal* storage_internal_;  // Not owned.
   // Desktop stubs don't actually store these, but defined to match constructor.

storage/src/ios/list_result_ios.h

@@ -1,4 +1,4 @@
-// Copyright 2021 Google LLC
+// Copyright 2025 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -20,9 +20,9 @@
 #include <memory> // For std::unique_ptr
 
 #include "firebase/storage/storage_reference.h"
-#include "storage/src/common/storage_internal.h"
-// It's okay for platform specific internal headers to include common internal headers.
-#include "storage/src/common/list_result_internal_common.h"
+// #include "storage/src/common/storage_internal.h" // Removed
+#include "storage/src/ios/storage_ios.h" // Added for iOS StorageInternal
+// #include "storage/src/common/list_result_internal_common.h" // Removed
 #include "storage/src/ios/fir_storage_list_result_pointer.h" // For FIRStorageListResultPointer
 
 // Forward declare Obj-C types
@@ -44,7 +44,7 @@ class ListResult;
 namespace internal {
 
 // Declare ListResultInternal a friend of ListResultInternalCommon for construction.
-class ListResultInternalCommon;
+// class ListResultInternalCommon; // Removed
 
 // Contains the iOS-specific implementation of ListResultInternal.
 class ListResultInternal {
@@ -83,7 +83,7 @@ class ListResultInternal {
   friend class firebase::storage::ListResult;
   // For ListResultInternalCommon's constructor and access to app_ via
   // storage_internal().
-  friend class ListResultInternalCommon;
+  // friend class ListResultInternalCommon; // Removed
 
   // Converts an NSArray of FIRStorageReference objects to a C++ vector of
   // C++ StorageReference objects.